1892304 - Include the FxA uid as an optional meta property to the BackupManifest v1 schema

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

markh pointed out that it'd be good future-proofing to include the FxA uid inside of the backup-manifest.json.

The meta property seems like a good place to tuck this in. It should be an optional property, since not all users will be signed in at backup time.

Since we haven't shipped this thing yet, we don't need to do a schema version bump or anything special.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Here's one way to get the FxA sign-in state and uid:

const { UIState } = ChromeUtils.importESModule(
  "resource://services-sync/UIState.sys.mjs"
);
let fxaState = UIState.get();
if (fxaState.status == UIState.STATUS_SIGNED_IN) {
  let uid = fxaState.uid;

  // Poke uid into manifest object here
}

Is that the best way, markh?

Comment 2

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

That seems perfect, thanks. As mentioned in slack, you should also find an email property on that fxaState object, so including that also couldn't hurt if there's a possibility we want to show that account info to the user.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1892304 - Add the FxA uid and email to the backup manifest if signed in when creating a backup. r?#backup-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df6b9812d5f5
Add the FxA uid and email to the backup manifest if signed in when creating a backup. r=backup-reviewers,kpatenio

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/df6b9812d5f5