1894301 - Backup manifest schema violation warning emitted when not signed in

Status: RESOLVED FIXED

(Firefox :: Profile Backup, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Don't be signed into a Mozilla account
2. Visit chrome://browser/content/backup/debug.html
3. Click "Create backup"
4. Open the Browser Console

ER:

Perhaps some logging, but no errors.

AR:

This error is displayed:

BackupService: Backup manifest does not conform to schema: 
Object { version: 1, meta: {…}, resources: {…} }
 
Object { "$schema": "https://json-schema.org/draft/2019-09/schema", "$id": "file:///BackupManifest.schema.json", title: "BackupManifest", description: "A schema for the backup-manifest.json file for profile backups created by the BackupService", type: "object", properties: {…}, required: (3) […] }
 
Object { valid: false, parsedValue: undefined, error: JsonSchemaValidatorError }
BackupService.sys.mjs:283:25

This is because of some properties set to undefined in the meta object when not signed into an account.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1894301 - Avoid schema violation before writing backup manifest when not signed into an account. r?#backup-reviewers!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1892304

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/262c96e73c70
Avoid schema violation before writing backup manifest when not signed into an account. r=backup-reviewers,kpatenio

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/262c96e73c70