1892400 - Support using the remoting service to send command lines after startup

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Dave Townsend [:mossop]]

Currently we can only send a command line to a running Firefox in a specific point during early startup. There is nothing stopping us making this available more generally to allow sending messages to other instances at any point during the application lifecycle.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1892400: Remove the unnecessary response and success arguments. r=jhirsch!,glandium!

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1892400: Remote service should live for the lifetime of the application. r=jhirsch!

Comment 3

[Dave Townsend [:mossop]]

Attachment: Bug 1892400: Add a method to send a command line to a running instance. r=jhirsch!

Comment 4

[Dave Townsend [:mossop]]

Attachment: Bug 1892400: Windows remote client should send the intended command line. r=jhirsch!,rkraesig!

Currently the windows client sends the current process command line which is
potentially an issue since some of those arguments may have been consumed
already. It will also not support sending custom command lines after startup.

Comment 5

[Dave Townsend [:mossop]]

Attachment: Bug 1892400: Remove the startup token from the non-unix remote implementations. r=jhirsch!,glandium!

This simplifies the call signatures of all versions since this is only needed in unix.

Comment 6

[Dave Townsend [:mossop]]

Attachment: Bug 1892400: Always use the full profile path to identify profiles for the remoting service. r=jhirsch!,glandium!

With the new profiles implementation we need to be able to identify a running instance
regardless of whether it was launched as a named profile or not. This changes to prefer
using the full profile path as an identifier falling back to testing the profile name
for backwards compatibility.

Comment 7

[Mike Hommey [:glandium]]

Currently we can only send a command line to a running Firefox in a specific point during early startup.

I'm not sure what you mean here. If I firefox --jsconsole while firefox is running, that opens the jsconsole in the running firefox.

Comment 8

[Dave Townsend [:mossop]]

(In reply to Mike Hommey [:glandium] from comment #7)

Currently we can only send a command line to a running Firefox in a specific point during early startup.

I'm not sure what you mean here. If I firefox --jsconsole while firefox is running, that opens the jsconsole in the running firefox.

I mean from a Firefox process. We can launch a new Firefox process yes but that is unneeded overhead.

Comment 9

[Mike Hommey [:glandium]]

I see what you mean now. Thank you for the clarification.

Comment 10

[Zach Hoffman [:zrhoffman]]

Depends on bug 1906260 because https://phabricator.services.mozilla.com/D217569 is part of the patch stack.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82111a5fc831
Remove the unnecessary response and success arguments. r=jhirsch,glandium
https://hg.mozilla.org/integration/autoland/rev/beb16099057e
Windows remote client should send the intended command line. r=jhirsch,rkraesig
https://hg.mozilla.org/integration/autoland/rev/a0bb5ed531ce
Remove the startup token from the non-unix remote implementations. r=jhirsch,glandium
https://hg.mozilla.org/integration/autoland/rev/bf5862fa2a1d
Always use the full profile path to identify profiles for the remoting service. r=jhirsch,glandium
https://hg.mozilla.org/integration/autoland/rev/7c12bcdfd937
Remote service should live for the lifetime of the application. r=jhirsch
https://hg.mozilla.org/integration/autoland/rev/25b37643e1fe
Add a method to send a command line to a running instance. r=jhirsch

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing Gtest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/3c69f0b52085ffe6c4619391f19c0f9cf41244d2

Push with failures

Failure log -> Hit MOZ_CRASH([Parent 676, Main Thread] ###!!! ASSERTION: Unexpected non-ASCII character: '!(aStr2[i] & ~0x7F)', file /builds/worker/checkouts/gecko/xpcom/string/nsCharTraits.h:337)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bc2789652db
Remove the unnecessary response and success arguments. r=jhirsch,glandium
https://hg.mozilla.org/integration/autoland/rev/c62cf2fcd7a1
Windows remote client should send the intended command line. r=jhirsch,rkraesig
https://hg.mozilla.org/integration/autoland/rev/56ee67701929
Remove the startup token from the non-unix remote implementations. r=jhirsch,glandium
https://hg.mozilla.org/integration/autoland/rev/ab78fe7e1029
Always use the full profile path to identify profiles for the remoting service. r=jhirsch,glandium
https://hg.mozilla.org/integration/autoland/rev/dab3567a33f3
Remote service should live for the lifetime of the application. r=jhirsch
https://hg.mozilla.org/integration/autoland/rev/259fd33ad3af
Add a method to send a command line to a running instance. r=jhirsch

Comment 14

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/8bc2789652db
https://hg.mozilla.org/mozilla-central/rev/c62cf2fcd7a1
https://hg.mozilla.org/mozilla-central/rev/56ee67701929
https://hg.mozilla.org/mozilla-central/rev/ab78fe7e1029
https://hg.mozilla.org/mozilla-central/rev/dab3567a33f3
https://hg.mozilla.org/mozilla-central/rev/259fd33ad3af