1906260 - Remove the -no-remote command line argument

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, task)

Description

[Dave Townsend [:mossop]]

When Firefox is running it normally starts a remoting server that allows other Firefox instances to communicate with it. When a new instance of Firefox starts it uses a remoting client to detect if an existing instance is already running and if so pass any command line arguments to it so only one instance is ever running for a given profile.

We have for a long time had a -no-remote command line argument that disables both remoting server and client. Prior to Firefox 67 this was used for running multiple instances of Firefox at the same time however now the remoting system is scoped to the profile in use so as long as you are running with different profiles you do not need the -no-remote command line argument. We also support a -new-instance argument which disables just the remoting client at startup and so allows startup to proceed ignoring any running instances using the same profile. Using either of these arguments when there is already a running instance results in the user seeing a dialog explaining that the profile is in use and (on some platforms) offering to kill the existing instance.

Many tools and documentation still recommend using the -no-remote argument and it has caused unexpected behaviour in the past causing users to file bugs and support requests. Additionally we plan to make more use of the remoting system to support the new multiple profiles feature.

In order to remove this confusing footgun and so we can rely on the remoting server always be enabled in any running instance of Firefox I am planning on removing the -no-remote command line argument from Firefox. Note that the -new-instance command line argument will remain.

This would also include removing the MOZ_NO_REMOTE environment variable which does the same thing as the -no-remote command line argument.

Comment 1

[Mike Hommey [:glandium]]

There are ton of things that use -no-remote, in-tree and probably out-of-tree. When we removed the -remote argument, we reintroduced it for backwards compatibility, albeit not actually doing what it used to do. Maybe we should do something similar here, e.g. keeping the option as a no-op.

Comment 2

[Christian Holler (:decoder)]

(In reply to Mike Hommey [:glandium] from comment #1)

There are ton of things that use -no-remote, in-tree and probably out-of-tree. When we removed the -remote argument, we reintroduced it for backwards compatibility, albeit not actually doing what it used to do. Maybe we should do something similar here, e.g. keeping the option as a no-op.

100% agree, at least temporarily. Removing this is likely going to break a lot of automation.

Comment 3

[Dave Townsend [:mossop]]

Yes my intent was to essentially keep checking for the argument but just make it a no-op. Though as far as I'm aware the other case would just cause a warning to show up in the console.

Comment 4

[Dave Townsend [:mossop]]

Attachment: Bug 1906260: Remove the -no-remote command line argument. r=glandium!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82cd657ce425
Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures @ test_interactive_widget.html & puppeteer test failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/a0a746684408976615b094ba4c066e02461e2f90

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | layout/base/tests/test_interactive_widget.html | Test timed out

also these Puppeteer test

Failure log -> TEST-UNEXPECTED-FAIL | Launcher specs Puppeteer Puppeteer.launch should filter out ignored default arguments in Chrome (launcher.spec.js) | expected PASS

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0866652e65f
Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f0866652e65f

Comment 9

[tszentpeteri]

Backed out for causing mochitest failures on browser_startup_mainthreadio.js

• Backout link
• Push with failures
• Failure Log:

[task 2024-08-09T07:36:56.985Z] 07:36:56     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_mainthreadio.js | The IO interposer should be enabled in builds that are not RELEASE_OR_BETA - 
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO - known main thread IO paths during before profile selection:
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO -   D:\task_172318779903395\AppData\Roaming\Mozilla\Firefox\Crash Reports\InstallTime20* - condition: true, stat: 1, read: 1, write: 2, close: 1, listedPath: UAppData:Crash Reports/InstallTime20*
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO -   D:\task_172318779903395\AppData\Roaming\Mozilla\Firefox\Crash Reports\LastCrash - condition: true, stat: 1, read: 1, listedPath: UAppData:Crash Reports/LastCrash
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO -   D:\task_172318779903395\AppData\Roaming\Mozilla\Firefox\profiles.ini - condition: true, ignoreIfUnused: true, read: 1, stat: 1, listedPath: UAppData:profiles.ini
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner - condition: true, stat: 1, listedPath: ProfD:
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini - write: 18, close: 1, listedPath: ProfLD:compatibility.ini
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\parent.lock - condition: true, stat: 1, listedPath: ProfD:parent.lock
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\minidumps - condition: true, stat: 1, listedPath: ProfD:minidumps
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO -   D:\task_172318779903395\build\application\firefox\browser\defaults\preferences - condition: true, stat: 1, listedPath: XCurProcD:defaults/preferences
[task 2024-08-09T07:36:56.989Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\startupCache\scriptCache-child-current.bin - condition: true, stat: 1, listedPath: ProfLDS:startupCache/scriptCache-child-current.bin
[task 2024-08-09T07:36:56.990Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\startupCache\scriptCache-child.bin - condition: true, stat: 1, listedPath: ProfLDS:startupCache/scriptCache-child.bin
[task 2024-08-09T07:36:56.990Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\startupCache\scriptCache-current.bin - condition: true, stat: 1, listedPath: ProfLDS:startupCache/scriptCache-current.bin
[task 2024-08-09T07:36:56.990Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\startupCache\scriptCache.bin - condition: true, stat: 1, listedPath: ProfLDS:startupCache/scriptCache.bin
[task 2024-08-09T07:36:56.990Z] 07:36:56     INFO -   D:\task_172318779903395\build\application\firefox\defaults\pref\channel-prefs.js - condition: true, stat: 1, read: 1, close: 1, listedPath: PrfDef:channel-prefs.js
[task 2024-08-09T07:36:56.990Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\prefs.js - stat: 1, read: 1, close: 1, listedPath: PrefD:prefs.js
[task 2024-08-09T07:36:56.990Z] 07:36:56     INFO -   C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\user.js - stat: 1, read: 1, close: 1, listedPath: PrefD:user.js
[task 2024-08-09T07:36:56.991Z] 07:36:56     INFO - (PoisonIOInterposer) stat - D:\task_172318779903395\AppData\Roaming\Mozilla\Firefox\Crash Reports\InstallTime20240808193837
[task 2024-08-09T07:36:56.991Z] 07:36:56     INFO - (PoisonIOInterposer) read - D:\task_172318779903395\AppData\Roaming\Mozilla\Firefox\Crash Reports\InstallTime20240808193837
[task 2024-08-09T07:36:56.992Z] 07:36:56     INFO - (PoisonIOInterposer) stat - D:\task_172318779903395\AppData\Roaming\Mozilla\Firefox\Crash Reports\LastCrash
[task 2024-08-09T07:36:56.992Z] 07:36:56     INFO - Buffered messages finished
[task 2024-08-09T07:36:56.993Z] 07:36:56     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_mainthreadio.js | unexpected stat on C:\Users\task_172318779903395\AppData\Local\Temp\firefox-default\parent.lock before profile selection - 
[task 2024-08-09T07:36:56.993Z] 07:36:56     INFO - Stack trace:
[task 2024-08-09T07:36:56.994Z] 07:36:56     INFO -   0x7ffa6ab0ba81
[task 2024-08-09T07:36:56.994Z] 07:36:56     INFO -   nsLocalFile::ResolveAndStat
[task 2024-08-09T07:36:56.994Z] 07:36:56     INFO -   XREMain::XRE_main
[task 2024-08-09T07:36:56.994Z] 07:36:56     INFO - (PoisonIOInterposer) stat - C:\Users\task_172318779903395\AppData\Local\Temp\firefox-default\parent.lock
[task 2024-08-09T07:36:56.995Z] 07:36:56     INFO - (PoisonIOInterposer) stat - D:\task_172318779903395\AppData\Roaming\Mozilla\Firefox\profiles.ini
[task 2024-08-09T07:36:56.995Z] 07:36:56     INFO - (PoisonIOInterposer) stat - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner
[task 2024-08-09T07:36:56.997Z] 07:36:56     INFO - (PoisonIOInterposer) stat - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\parent.lock
[task 2024-08-09T07:36:56.997Z] 07:36:56     INFO - (PoisonIOInterposer) stat - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\minidumps
[task 2024-08-09T07:36:56.998Z] 07:36:56     INFO - (PoisonIOInterposer) write - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini
[task 2024-08-09T07:36:56.999Z] 07:36:56     INFO - (PoisonIOInterposer) write - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini
[task 2024-08-09T07:36:56.999Z] 07:36:56     INFO - (PoisonIOInterposer) write - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini
[task 2024-08-09T07:36:57.000Z] 07:36:57     INFO - (PoisonIOInterposer) write - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini
[task 2024-08-09T07:36:57.000Z] 07:36:57     INFO - (PoisonIOInterposer) write - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini
[task 2024-08-09T07:36:57.001Z] 07:36:57     INFO - (PoisonIOInterposer) write - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini
[task 2024-08-09T07:36:57.002Z] 07:36:57     INFO - (PoisonIOInterposer) write - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini
[task 2024-08-09T07:36:57.002Z] 07:36:57     INFO - (PoisonIOInterposer) write - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini
[task 2024-08-09T07:36:57.003Z] 07:36:57     INFO - (PoisonIOInterposer) write - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\compatibility.ini
[task 2024-08-09T07:36:57.004Z] 07:36:57     INFO - (PoisonIOInterposer) read - D:\task_172318779903395\build\application\firefox\defaults\pref\channel-prefs.js
[task 2024-08-09T07:36:57.005Z] 07:36:57     INFO - (PoisonIOInterposer) stat - D:\task_172318779903395\build\application\firefox\browser\defaults\preferences
[task 2024-08-09T07:36:57.006Z] 07:36:57     INFO - (PoisonIOInterposer) read - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\prefs.js
[task 2024-08-09T07:36:57.006Z] 07:36:57     INFO - (PoisonIOInterposer) stat - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\prefs.js
[task 2024-08-09T07:36:57.007Z] 07:36:57     INFO - (PoisonIOInterposer) read - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\user.js
[task 2024-08-09T07:36:57.007Z] 07:36:57     INFO - (PoisonIOInterposer) stat - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\startupCache\scriptCache-child.bin
[task 2024-08-09T07:36:57.008Z] 07:36:57     INFO - (PoisonIOInterposer) stat - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\startupCache\scriptCache-child-current.bin
[task 2024-08-09T07:36:57.009Z] 07:36:57     INFO - (PoisonIOInterposer) stat - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\startupCache\scriptCache.bin
[task 2024-08-09T07:36:57.010Z] 07:36:57     INFO - (PoisonIOInterposer) stat - C:\Users\task_172318779903395\AppData\Local\Temp\tmpffk64djz.mozrunner\startupCache\scriptCache-current.bin
[task 2024-08-09T07:36:57.010Z] 07:36:57     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_mainthreadio.js | stat on D:\task_172318779903395\AppData\Roaming\Mozilla\Firefox\Crash Reports\InstallTime20* as many times as expected before profile selection - 0 >= 0 - 

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47ef7f983aba
Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/47ef7f983aba