1892463 - Translations Binding is Calling safeInvalidateBrowserToolbarView too much

Status: NEW

(Firefox for Android :: Translations, defect, P2)

Description

[Olivia Hall [:olivia]]

This is likely contributing and making the toolbar issue worse with overlapping icons in bug 1862102.

With a debugger breakpoint set at ActionContainer.kt#96 I saw over 30 invalidation calls occurring from the TranslationsBinding. It should be possible to make this invalidation more targeted, since only some of the state changes impact showing the toolbar state.

Important toolbar state calls:

• When the page should show the icon: isExpectedTranslate
• When the translations feature should popup: isOfferTranslate
• When we need to turn the icon purple and show different content description: isTranslated
• Likely some around when reader mode is engaged

Comment 1

[Olivia Hall [:olivia]]

This is more a code health issue, removing it from the translations roadmap. (I think this has been resolved or else mitigated in other toolbar redesing work as well.)

Comment 2

[Olivia Hall [:olivia]]

Moving the priority up because this overcalling could also be a factor in bug 1909816.