1892659 - Allow closing all of current window's duplicate tabs in tab overflow menu.

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

That's a part of bug 1891797 comment 0's spec I didn't have time to do, but should be reasonable.

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1892659 - Add an all tabs menu item to deduplicate all open tabs r?dao!,emilio!

Comment 3

[Chris H-C :chutten]

I might've nerdsniped (become nerdsnapt?) myself into this.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Looks like amylee was heading in this direction too - here's a Figma spec for closing duplicate tabs across a window: https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?type=design&node-id=11928%3A16684&mode=design&t=NXQJBHHWAHC1Y8hl-1

Comment 6

[Amy Lee [:amylee] UX]

This is also a related bug. https://bugzilla.mozilla.org/show_bug.cgi?id=1893741

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a5c2919ba1f
Add an all tabs menu item to deduplicate all open tabs r=dao,emilio,fluent-reviewers,tabbrowser-reviewers,flod

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_multiselect_tabs_close_duplicate_tabs.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_close_duplicate_tabs.js | Test timed out -

Comment 9

[Chris H-C :chutten]

Ah, whoopsie, forgot to flip the pref so we wouldn't get the dialog during the test.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c7b1942b455
Add an all tabs menu item to deduplicate all open tabs r=dao,emilio,fluent-reviewers,tabbrowser-reviewers,flod

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4c7b1942b455

Comment 12

[Pascal Chevrel:pascalc]

Could you prepare a release note addition? Thanks
https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla

Comment 13

[Chris H-C :chutten]

Release Note Request (optional, but appreciated)
[Why is this notable]: Tab management feature
[Affects Firefox for Android]: No
[Suggested wording]: All tabs menu item that closes all duplicate tabs
[Links (documentation, blog post, etc)]: None

Comment 14

[Pascal Chevrel:pascalc]

Note added to Nightly 127 release notes with this wording:

It is now possible to close all duplicate tabs in a window with the Close duplicate tabs command available from the List all tabs widget in the tab bar or the context menu a tab.

Comment 15

[Chris H-C :chutten]

...or the context menu a tab

Might be a grammar error there?

Comment 16

[Pascal Chevrel:pascalc]

Yes, I updated that to " or a tab context menu".

Comment 17

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified on Firefox 127.0b4 that the duplicate tabs can be closed by using "Close duplicate tabs" from the "List all tabs" dropdown.

Tests were performed on macOS 14.5, Windows 11 and Ubuntu 24.04.

Comment 18

[Amy Lee [:amylee] UX]

Hi,

There are some string changes to "Close Duplicate Tabs". Should a new bug be filed for the changes?

There will also be string changes to https://bugzilla.mozilla.org/show_bug.cgi?id=1891797 as well (closing duplicate tabs in the context menu).

Thanks!

Comment 19

[Pascal Chevrel:pascalc]

(In reply to Amy Lee [:amylee] UX from comment #18)

Hi,

There are some string changes to "Close Duplicate Tabs". Should a new bug be filed for the changes?

There will also be string changes to https://bugzilla.mozilla.org/show_bug.cgi?id=1891797 as well (closing duplicate tabs in the context menu).

Thanks!

This is a question for the PM in charge of this feature, not the release manager.