Closed Bug 1892659 Opened 3 months ago Closed 2 months ago

Allow closing all of current window's duplicate tabs in tab overflow menu.

Categories

(Firefox :: Tabbed Browser, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
127 Branch
Tracking Status
relnote-firefox --- 127+
firefox127 --- verified

People

(Reporter: emilio, Assigned: chutten)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-quality-foundation])

Attachments

(1 file)

That's a part of bug 1891797 comment 0's spec I didn't have time to do, but should be reasonable.

Summary: Allow you to close duplicate tabs in tab overflow menu. → Allow closing all of current window's duplicate tabs in tab overflow menu.
Whiteboard: [fidefe-quality-foundation]
Duplicate of this bug: 1129456
Blocks: tab-manager
Assignee: nobody → chutten
Status: NEW → ASSIGNED

I might've nerdsniped (become nerdsnapt?) myself into this.

Attachment #9398486 - Attachment description: Bug 1892659 - Add a context menu item to deduplicate all open tabs r?dao!,emilio! → Bug 1892659 - Add an all tabs menu item to deduplicate all open tabs r?dao!,emilio!
Duplicate of this bug: 1893728

Looks like amylee was heading in this direction too - here's a Figma spec for closing duplicate tabs across a window: https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?type=design&node-id=11928%3A16684&mode=design&t=NXQJBHHWAHC1Y8hl-1

Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a5c2919ba1f
Add an all tabs menu item to deduplicate all open tabs r=dao,emilio,fluent-reviewers,tabbrowser-reviewers,flod

Backed out for causing mochitests failures in browser_multiselect_tabs_close_duplicate_tabs.js.

Flags: needinfo?(chutten)

Ah, whoopsie, forgot to flip the pref so we wouldn't get the dialog during the test.

Flags: needinfo?(chutten)
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c7b1942b455
Add an all tabs menu item to deduplicate all open tabs r=dao,emilio,fluent-reviewers,tabbrowser-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Flags: needinfo?(chutten)

Release Note Request (optional, but appreciated)
[Why is this notable]: Tab management feature
[Affects Firefox for Android]: No
[Suggested wording]: All tabs menu item that closes all duplicate tabs
[Links (documentation, blog post, etc)]: None

relnote-firefox: --- → ?
Flags: needinfo?(chutten)
Regressions: 1895641

Note added to Nightly 127 release notes with this wording:

It is now possible to close all duplicate tabs in a window with the Close duplicate tabs command available from the List all tabs widget in the tab bar or the context menu a tab.

...or the context menu a tab

Might be a grammar error there?

Flags: needinfo?(pascalc)

Yes, I updated that to " or a tab context menu".

Flags: needinfo?(pascalc)
Flags: qe-verify+

Verified on Firefox 127.0b4 that the duplicate tabs can be closed by using "Close duplicate tabs" from the "List all tabs" dropdown.

Tests were performed on macOS 14.5, Windows 11 and Ubuntu 24.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Hi,

There are some string changes to "Close Duplicate Tabs". Should a new bug be filed for the changes?

There will also be string changes to https://bugzilla.mozilla.org/show_bug.cgi?id=1891797 as well (closing duplicate tabs in the context menu).

Thanks!

Flags: needinfo?(pascalc)

(In reply to Amy Lee [:amylee] UX from comment #18)

Hi,

There are some string changes to "Close Duplicate Tabs". Should a new bug be filed for the changes?

There will also be string changes to https://bugzilla.mozilla.org/show_bug.cgi?id=1891797 as well (closing duplicate tabs in the context menu).

Thanks!

This is a question for the PM in charge of this feature, not the release manager.

Flags: needinfo?(pascalc)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: