1892846 - Disable translate-full-page button when same language is selected

Status: VERIFIED FIXED

(Firefox :: Translations, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

Description

The SelectTranslationsPanel allows same-language translation, but the FullPageTranslationsPanel does not.

If the same language is ever selected in the SelectTranslationsPanel, we need to ensure that the translate-full-page button is disabled.

---

Steps to implement

• Disable the translate-full-page button if the same language is selected in the SelectTranslationsPanel.

---

Tests to implement

• Ensure all pre-existing test cases assert this relationship on every relevant panel view assertion.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1892846 - Disable translate-full-page on same language r=#translations-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bab4df44e770
Disable translate-full-page on same language r=translations-reviewers,gregtatum

Comment 3

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/bab4df44e770

Comment 4

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to replicate the behavior described in Comment 0 on Firefox Nightly 126.0a1 (2024-04-01), using macOS 14.4 by setting the browser.translations.select.enable pref to true from about:config and selecting the same language in SelectTranslationsPanel.
Verified as fixed on Firefox 127.0b9, build ID 20240531105723, using Windows 11, Ubuntu 22.04 and macOS 14.4 and the "Translate full page" button from the SelectTranslationsPanel is now disabled when the same language is selected.