1892848 - Improve SelectTranslationsPanel translate via keyboard navigation

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

Description

When initially talking to the a11y team about how translate should work when selecting a dropdown menu directly via keyboard, they said it would make sense to translate when the menulist gets a blur event.

This is the overall right idea, but it makes it awkward if you've just changed the from-language and then you tab over to change the to-language. The fromMenuList receives its blur event, and then it starts translating.

A better heuristic would be if the textarea receives focus after a direct keyboard language change. This way the user can Tab or Shift + Tab between the two language menu lists and a translation won't trigger until they Tab onto the textarea where they expect the translation to occur.

---

Steps to implement

• Remove the translate on blur event from the menu list on direct language change.
• Add a translate on focus event to the textarea on direct language change.

---

Tests to implement

• Ensure that the test cases cover both conditions of pressing Enter to translate, or focusing the textarea element.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1892848 - Refactor SelectTranslationsPanel translation event listeners r=#translations-reviewers!

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1892848 - Rework translate on keyboard navigation r=#translations-reviewers!

Reworks the SelectTranslationsPanel translate on keyboard
navigation events to translate when the textarea is focused
after a langauge change, instead of on when the menu list
is blurred.

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1892848 - Init translate event listeners on open r=#translations-reviewers!

Depends on D208417

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1892848 - Focus last-interacted menulist on translation failure r=#translations-reviewers!

Ensures that the focus shifts back to the last-interacted
menu list if the translation fails, so that users utilizing
keyboard navigation can pick up where they left off.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80b35b690e46
Refactor SelectTranslationsPanel translation event listeners r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/cd9227638299
Rework translate on keyboard navigation r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/0273961a00f1
Init translate event listeners on open r=translations-reviewers,gregtatum

Comment 6

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/80b35b690e46
https://hg.mozilla.org/mozilla-central/rev/cd9227638299
https://hg.mozilla.org/mozilla-central/rev/0273961a00f1