Closed Bug 1892853 Opened 5 months ago Closed 5 months ago

Ensure SelectTranslationsPanel footer buttons wrap correctly

Categories

(Firefox :: Translations, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
127 Branch
Tracking Status
firefox127 --- verified

People

(Reporter: nordzilla, Assigned: nordzilla)

References

Details

Attachments

(2 files)

Description

The SelectTranslationsPanel button group has the start-justified copy button and the end-justified translate-full-page button and done-button.

There is potential, in some locales with longer localized text, for these buttons to overflow the horizontal space allotted to them.

In this situation, the end-justified buttons need to move down to the next row, but maintain their end-justification (see attached image).


Steps to implement

  • Modify the CSS to support this stiuation.

Tests to implement

  • I'm not sure that this is easily testable in automation, since our test suite uses the English locale which does not encounter this overflow.

Ensures that the SelectTranslationsPanel footer buttons
within the moz-button-group footer wrap correctly
when localized text causes the buttons to overflow
the available horizontal space within the panel.

Attachment #9398046 - Attachment description: WIP: Bug 1892853 - Ensure SelectTranslationsPanel footer buttons wrap correctly → Bug 1892853 - Ensure SelectTranslationsPanel footer buttons wrap correctly r=#desktop-theme-reviewers!
Pushed by enordin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/792c98927914 Ensure SelectTranslationsPanel footer buttons wrap correctly r=desktop-theme-reviewers,gregtatum,dao
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch

Tested this issue on nighlty 128.0a1 and on Firefox beta 127.0b8 (browser.translations.select.enable = true), I can confirm that the issue is fixed, verified on Windows 10, Ubuntu 22 and on macOS 12.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: