1892957 - Add sidebar position settings to the Customize Sidebar menu

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Sarah Clements [:sclements]]

We have a pre-existing pref for this ("sidebar.position_start"), but since we'll be persisting many other settings pertaining to the sidebar (see bug 1891777) we'll need to decide if it makes sense to even keep the pref versus having one source of truth. Its quite likely very few users know about this pref, since the only way you can currently change the sidebar position is to manually flip it.

Regardless of the approach we take, we'll need to add the option to display the sidebar on the left or right in "Sidebar settings" section per the spec.

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=#sidebar-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd06757d8344
Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster

Comment 3

[Cristian Tuns]

Backed out for causing bc failures in browser_sidebar_move.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/sidebar/browser_sidebar_move.js | Correct ordinal (end) - [["sidebar-main","5"],["sidebar-box","4"],["sidebar-splitter","5"],["appcontent","2"]] deepEqual [["sidebar-main",5],["sidebar-box",4],["sidebar-splitter",3],["appcontent",2]] -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f9a1f21dbb2
Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1f9a1f21dbb2