1891775 - Create a "Customize Sidebar" menu with default options

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement)

Description

[Sarah Clements [:sclements]]

Create a new sidebar panel for a "Customize Sidebar" menu (that string may not be final, so don't localize it yet) that has a gear icon as an entry point in the sidebar launcher. See spec here.

• Only do basic form styling - don't make it pixel perfect - because the visual design is not final and the reusable components team is planning to create a moz-form that we can utilize.
• Don't create all form options, only add History and Synced tabs in the "the “Firefox Tools” (copy probably not final) section. All sections will be added in separate bugs.
• Selecting and delecting History and Synced Tabs should add and remove those icons from the sidebar launcher.
• Add basic test coverage
• Telemetry requirements TBD

We’ll also need to do work to persist the settings of everything in this menu across windows and sessions; we probably want to utilize the existing sidebar properties we already use for this purpose. That should probably blocked on bug 1885894, or at least sync with Nikki on the implementation details because we don't want to add it to XULstore. I'll spin this off to a separate bug.

Comment 1

[Sarah Clements [:sclements]]

A few other things to point out is that adding or removing one of the "Firefox Tools", should not change the entry points to the toolbar menu. It shouldn't affect any of the sidebars registered in browser-sidebar here. The launcher should probably have its own separate Map of "tools", because the selection will ultimately be different based on what users select to show there and we want to preserve the order (and UX/product eventually want users to be able to rearrange "tools" via drag and drop).

I'm thinking we can combine topActions and extensions being added here (rename to tools or similar because they will be positioned on the top without vertical tabs, or moved to the bottom with them visible). Let me know if you think it makes sense to incorporate this change in your patch or if it should be a follow-up.

Comment 2

[Kelly Cochrane [:kcochrane]]

(In reply to Sarah Clements [:sclements] from comment #1)

A few other things to point out is that adding or removing one of the "Firefox Tools", should not change the entry points to the toolbar menu. It shouldn't affect any of the sidebars registered in browser-sidebar here. The launcher should probably have its own separate Map of "tools", because the selection will ultimately be different based on what users select to show there and we want to preserve the order (and UX/product eventually want users to be able to rearrange "tools" via drag and drop).

You know I actually worked on this yesterday, and am just now seeing this comment, but I actually did switch bottomActions to a map initially. I'm not sure we want to stick with that though because in order to preserve ordering when they enable/disable History/Synced Tabs, I'm not sure how I'd insert the button element back in the proper position with a Map. I removed them as an array entirely for now and am just templating each button out separately for now with a wrapping when() conditional for if they have the respective prefs switched on. What do you think though?

I'm thinking we can combine topActions and extensions being added here (rename to tools or similar because they will be positioned on the top without vertical tabs, or moved to the bottom with them visible). Let me know if you think it makes sense to incorporate this change in your patch or if it should be a follow-up.

I'm okay to do this as part of my patch. Maybe we can call it tools-and-extensions or some such.

Comment 3

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1891775 - Create a 'Customize Sidebar' menu with default options

Comment 4

[Sarah Clements [:sclements]]

A follow-up to our discussion about this on slack: I talked to Yulia about the tools order in the launcher and the Customize Sidebar Menu form (we're gonna start calling the launcher the "collapsed sidebar" going forward, btw).

Tabs from Other Devices will be first, Bookmarks second in both places (so default options in the collapsed sidebar). If a user deselects Bookmarks in the menu to remove it, for example, it removes it from the list/Map. If they add it back, or add an extension, those are added to the collapsed sidebar in the order in which they are added (so vertically - the first is at the top, subsequent icons underneath). We'll go through this in the handover later today as well :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15f3e112994e
Create a 'Customize Sidebar' menu with default options r=desktop-theme-reviewers,sidebar-reviewers,fluent-reviewers,jsudiaman,bolsson,sclements,flod,sfoster

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_all_files_referenced.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/1703f6a8416d302d6ea29b6430426a5964b5d26e
Log link: https://treeherder.mozilla.org/logviewer?job_id=457521840&repo=autoland&lineNumber=2054

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbbb4693be30
Create a 'Customize Sidebar' menu with default options r=desktop-theme-reviewers,sidebar-reviewers,fluent-reviewers,jsudiaman,bolsson,sclements,flod,sfoster

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing build bustages.

• Backout link
• Push with failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e2ec3a3b738
Create a 'Customize Sidebar' menu with default options r=desktop-theme-reviewers,sidebar-reviewers,fluent-reviewers,jsudiaman,bolsson,sclements,flod,sfoster

Comment 10

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/3e2ec3a3b738