1893083 - Implement the context menu on urlbar results

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1893083: Open url in new target by meta key

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1893083: Open url in new target by middle click

Depends on D208699

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1893083: Open urlbar result via context menu

Depends on D208700

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1893083: Avoid open in new target feature for result not having url

Depends on D208701

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1893083: Avoid open in new target feature for result that provides search mode

Depends on D208702

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1893083: Apply open in new target feature to switch to tab result

Depends on D208703

Comment 7

[BugBot [:suhaib / :marco]]

The following patches are waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D208699	Bug 1893083: Open url in new target by meta key	daisuke	adw: Back Jun 14, 2024
D208700	Bug 1893083: Open url in new target by middle click	daisuke	adw: Back Jun 14, 2024
D208701	Bug 1893083: Open url in new target by context menu	daisuke	adw: Back Jun 14, 2024
D208702	Bug 1893083: Avoid open in new target feature for result not having url	daisuke	adw: Back Jun 14, 2024
D208703	Bug 1893083: Avoid open in new target feature for result that provides search mode	daisuke	adw: Back Jun 14, 2024
D208704	Bug 1893083: Apply open in new target feature to switch to tab result	daisuke	adw: Back Jun 14, 2024

:daisuke, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 8

[Daisuke Akatsuka (:daisuke)]

I'd like to narrow the scope of this bug to implement the context menu only.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0fc6d185d6a9
https://hg.mozilla.org/integration/autoland/rev/8e740dc5d64c
Open urlbar result via context menu r=desktop-theme-reviewers,adw,fluent-reviewers,bolsson,emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a26f7c2ceed0
https://hg.mozilla.org/integration/autoland/rev/59179694a9d3
Revert "Bug 1893083: Open urlbar result via context menu r=desktop-theme-reviewers,adw,fluent-reviewers,bolsson,emilio" for causing bc failures related to urlbar.

Comment 11

[Iulian Moraru]

Revert for causing bc failures related to urlbar.

• Push with failures

• Failure log

• Backout link

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/69a82eced804
https://hg.mozilla.org/integration/autoland/rev/f4e3bcb55ca7
Open urlbar result via context menu r=desktop-theme-reviewers,adw,fluent-reviewers,bolsson,emilio

Comment 13

[BMO Github Automation]

Authored by Daisuke Akatsuka
https://github.com/mozilla/enterprise-firefox/commit/0fc6d185d6a91e26b2558f6d31509d8718f2e13c
[enterprise-main] Bug 1893083: Open urlbar result via context menu r=desktop-theme-reviewers,adw,fluent-reviewers,bolsson,emilio

Authored by https://github.com/IulianMoraru
https://github.com/mozilla/enterprise-firefox/commit/a26f7c2ceed0d6b977f87db88f9e0c100cf31ceb
[enterprise-main] Revert "Bug 1893083: Open urlbar result via context menu r=desktop-theme-reviewers,adw,fluent-reviewers,bolsson,emilio" for causing bc failures related to urlbar.

Comment 14

[Daisuke Akatsuka (:daisuke)]

Hi! Do you know how to get the reason for the revert? According to the comment, there is an error from bc, but I want to know the exact test and the exact env.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

The revert was from the first attempt at landing in comment 9. As far as I know, the landing from comment 12 is still on track to be merged to main with the next autoland merge.

Comment 16

[amarc]

https://hg.mozilla.org/mozilla-central/rev/f4e3bcb55ca7