2064747 - Combine result context menu and three-dot-button menu

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Dão Gottwald [:dao]]

Bug 1893083 implemented a context menu for address bar results behind a pref. We should make it so that right-clicking and the result's three-dot menu produce the same options. That means unifying the menus, but gating the right-click trigger and today's context menu options behind the pref. In other words, with the pref off we'll get today's three-dot menu, and with the pref on both triggers will open the same menu with today's context menu and three-dot options combined.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2064747 - Render the urlbar result menu's separators. r?daisuke!

panel-list styles hr, not the separator element the menu creates, so a result menu's separators have been invisible since it moved to panel-list.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 2064747 - Combine a urlbar result's context menu and three-dot menu. r?daisuke!

With contextMenu.featureGate off, the three-dot menu is unchanged.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/80ae4003e55b
https://hg.mozilla.org/integration/autoland/rev/b3e20294f19e
Render the urlbar result menu's separators. r=daisuke

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd204a688747
https://hg.mozilla.org/integration/autoland/rev/2950c71d6e5d
Combine a urlbar result's context menu and three-dot menu. r=daisuke,fluent-reviewers,urlbar-reviewers,bolsson

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b3e20294f19e

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2950c71d6e5d

Comment 8

[BMO Github Automation]

Authored by https://github.com/daogottwald
https://github.com/mozilla/enterprise-firefox/commit/80ae4003e55bad247a3191d0be54da2a674290c8
[enterprise-main] Bug 2064747 - Render the urlbar result menu's separators. r=daisuke