1893336 - Ensure that SelectTranslationPanel closes when opening a new tab

Status: VERIFIED FIXED

(Firefox :: Translations, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

Description

The SelectTranslationsPanel is a panel that is opened at an arbitrary location on screen, tied to a specific piece of web content.

Switching to a new tab, or navigating to another page, would not make sense to keep the panel open.

We need to ensure that the panel closes in this scenario.

---

Steps to implement

• Add tabspecific="true" to the SelectTranslationsPanel markup.
• Add locationspecific="true" to the SelectTranslationsPanel markup.

---

Tests to implement

• Add a test that opens the panel and then opens a new tab, ensuring the panel closes.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1893336 - Ensure SelectTranslationsPanel closes on new tab r=#translations-reviewers!

Ensures that the SelectTranslationsPanel correctly
closes when a new tab is opened while the panel is
still open.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c81afe8dce3a
Ensure SelectTranslationsPanel closes on new tab r=translations-reviewers,gregtatum

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c81afe8dce3a

Comment 4

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Tested this issue on Firefox nighlty 128.0a1 and on Firefox beta 127.0b9 (flipping pref browser.translations.select.enable = true), I can confirm the issue is fixed, verified on Windows 10, Ubuntu 22 and on macOS 12, the panel closes in this scenario.