1893471 - Ensure that the translate-full-page button is hidden on sites where full-page translations is restricted

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

Description

There are cases in which Select Translations will work but Full Page Translations will not. Such cases include documents where the DOM nodes are not mutable, such as PDFs, and we cannot translate the full page, but we can translate selected text.

---

Steps to implement

• Check if the current page is restricted to FullPageTranslations and hide the button if so.

---

Tests to implement

• Add test cases on restricted pages to ensure that the button is not visible.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1893471 - Rename TranslationsParent.isRestrictedPage r=#translations-reviewers!

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1893471 - Rename getFullPageTranslationsActor r=#translations-reviewers!

Renames the TranslationsParent.isTranslationsActor function
to getFullPageTranslationsActor to be more clear about the
functionality and purpose of the actor being retrieved.

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1893471 - Handle failure to retrieve Translations actor r=#translations-reviewers!

Ensures that all locations where the SelectTranslationsPanel
would attempt to retrieve the FullPageTranslations actor
are handled gracefully if the FullPageTranslations actor
cannot be retrieved.

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1893471 - Ensure translate-full-page button is properly hidden r=#translations-reviewers!

Ensures that the translate-full-page button is hidden
from the SelectTranslationsPanel when Full Page Translations
is not available on the active page.

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: Bug 1893471 - Ensure Translations PDF test file has content r=#translations-reviewers!

The existing PDF file in the Translations test suite
has no content. Now that we're testing Select Translations
with PDFs, we need one with content.

Comment 6

[Erik Nordin [:nordzilla]]

Attachment: Bug 1893471 - Add test for Select Translations with PDFs r=#translations-reviewers!

Adds test infrastructure and a test case to test the
SelectTranslationsPanel functionality when a PDF
is the current page.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff250016a247
Rename TranslationsParent.isRestrictedPage r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/11c0eba9a87b
Handle failure to retrieve Translations actor r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/f854ec46d8a8
Ensure translate-full-page button is properly hidden r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/a72fc18e10be
Ensure Translations PDF test file has content r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/85b0e38344fa
Add test for Select Translations with PDFs r=translations-reviewers,gregtatum

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/ff250016a247
https://hg.mozilla.org/mozilla-central/rev/11c0eba9a87b
https://hg.mozilla.org/mozilla-central/rev/f854ec46d8a8
https://hg.mozilla.org/mozilla-central/rev/a72fc18e10be
https://hg.mozilla.org/mozilla-central/rev/85b0e38344fa

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Tested on Windows 11, Ubuntu 22 and macOS 12, I can confirm this issue is fixed, I verified with Firefox 128.0a1.
I will verify in Firefox beta, when the feature will be enabled there.