1893623 - Trigger autofill from the parent process

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P1)

Description

[Dimi Lee [:dimi]]

Currently, when users autocomplete a field for an address, credit card, or login, Firefox also "autofills" the relevant fields. Here is a quick summary of how we currently manage this process:

1. Users click on an input field, the autocomplete popup is displayed, and Firefox searches for options so users can choose which value to autocomplete.
2. AutoCompleteChild searches for the value to autocomplete based on the type of the input field, along with the entire profile. For example, when we autocomplete a cc-number field, we also send cc-name, cc-exp, etc., to the child process.
3. AutoCompleteController autocompletes the focused input.
4. AutoCompleteController notifies the corresponding module, which then autofills the remaining fields.

Currently, step 4 is triggered directly in the child process. This patch moves the logic of step 4 from the child process to the parent process. This change is a prerequisite for supporting autofill across frames and will also enable us not to send the entire profile in step 2.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1893623 - P1. Trigger autofill from the parent process r=#credential-management-reviewers

Currently, when users autocomplete a field for an address, credit card, or login, Firefox also "autofills"
the relevant fields. Here is a quick summary of how we currently manage this process:

1. Users click on an input field, the autocomplete popup is displayed, and Firefox searches for options
   so users can choose which value to autocomplete.
2. AutoCompleteChild searches for the value to autocomplete based on the type of the input field, along
   with the entire profile. For example, when we autocomplete a cc-number field, we also send cc-name, cc-exp, etc., to the child process.
3. AutoCompleteController autocompletes the focused input.
4. AutoCompleteController notifies the corresponding module, which then autofills the remaining fields.

Currently, step 4 is triggered directly in the child process. This patch moves the logic of step 4 from the
child process to the parent process. This change is a prerequisite for supporting autofill across frames and
will also enable us not to send the entire profile in step 2.

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1893623 - P2. Remove unused code r=#credential-management-reviewers

Depends on D208752

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17be8b47ebd8
P1. Trigger autofill from the parent process r=credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/a0a539195135
P2. Remove unused code r=credential-management-reviewers,sgalich

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/17be8b47ebd8
https://hg.mozilla.org/mozilla-central/rev/a0a539195135