1894889 - Trigger autocomplete action from the parent process

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P2)

Description

[Dimi Lee [:dimi]]

This issue is the follow-up of Bug 1893623. In Bug 1893623, we move address, credit card, login autofill from the child process to the parent process. The bug aims to move the processing of remaining actions that are triggered when users select an entry in the autocomplete drop from the child process to the parent process as well.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1894889 - Trigger autocomplete action from the parent process r=#credential-management-reviewers

This patch adds the following messages to the autocomplete item:

1. For address and credit card autofill, use the FormAutofill:FillForm message.
2. For login autofill, use the PasswordManager:OnFieldAutoComplete message.
3. For generated password autofill, use the PasswordManager:FillGeneratedPassword message.
   After adding the above three messages, every autocomplete item that performs an action
   upon being clicked has a corresponding fillMessageName.

Here is how the new architecture works:

1. Whenever a user selects an autocomplete entry, the AutoCompleteChild sends
   the AutoComplete:SelectEntry message to the parent process.
2. AutoCompleteParent extracts fillMessageName from the message and uses
   the prefix of the message name to determine which actor should process this message.
3. The OnFieldAutoCompleteEntrySelected method of the actor is called. The actor in
   the parent process determines what action to take.

Comment 2

[Dimi Lee [:dimi]]

HI :owlish , is it possible that someone in your team help take a look at this patch, thank!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/915204f44829
Trigger autocomplete action from the parent process r=credential-management-reviewers,geckoview-reviewers,NeilDeakin,owlish

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/915204f44829