1893643 - Implement table64

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P2)

Description

[Ben Visness [:bvisness]]

The memory64 proposal has been extended to include 64-bit table indices: https://github.com/WebAssembly/memory64/issues/51

Comment 1

[Sam Clegg]

I'm wondering that the likelyhood is if this being implemented in time the June CG meeting? I would love to have the stage4 vote there but I understand this was a late addition.

Comment 2

[Ben Visness [:bvisness]]

Work is progressing reasonably well and I hope to have it implemented by then, but I can't make any promises, sorry.

Comment 3

[Sam Clegg]

The toolchain parts (at least the ones I work on: llvm, wabt, binaryen, emscripten) have all been updated now.

In emscripten we continue to run a lowering pass to convert table64 to table32. Once the engine updates are done we can remove this lowering pass.

Comment 4

[Ben Visness [:bvisness]]

Attachment: Bug 1893643: Update wast to support table64. r=rhunt

Comment 5

[Ben Visness [:bvisness]]

Attachment: Bug 1893643: Implement table64 functionality. r=rhunt

Comment 6

[Ben Visness [:bvisness]]

Attachment: Bug 1893643: Update spec test harness error handling. r=rhunt

Depends on D213778

Comment 7

[Ben Visness [:bvisness]]

Attachment: Bug 1893643: Update memory64 spec tests. r=rhunt

Depends on D213817

Comment 8

[Sam Clegg]

I was curious about the status of the current WIP patches. Mostly wondering about the likelihood that they will land this week? If so we can potentially put a stage 4 vote on next weeks meeting agenda. Otherwise we can push until August (Since I'm OOO for the end of July meeting).

Comment 9

[Ryan Hunt [:rhunt]]

(In reply to Sam Clegg from comment #8)

I was curious about the status of the current WIP patches. Mostly wondering about the likelihood that they will land this week? If so we can potentially put a stage 4 vote on next weeks meeting agenda. Otherwise we can push until August (Since I'm OOO for the end of July meeting).

Sorry, but it's unlikely they'll land this week. And if they do, we have to do some quick fuzzing and perf testing we need to do before we can say it's done.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bb3a79f8b7e
Update wast to support table64. r=rhunt,supply-chain-reviewers
https://hg.mozilla.org/integration/autoland/rev/1eeed5905a2f
Implement table64 functionality. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/0a5557cbb59a
Update spec test harness error handling. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/204ed2f3fce9
Update memory64 spec tests. r=rhunt

Comment 11

[Serban Stanca [:SerbanS]]

Backed out for causing windows sm bustages.

• Backout link
• Push with failures
• Failure Log

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/8bb3a79f8b7e
https://hg.mozilla.org/mozilla-central/rev/1eeed5905a2f
https://hg.mozilla.org/mozilla-central/rev/0a5557cbb59a
https://hg.mozilla.org/mozilla-central/rev/204ed2f3fce9

Comment 13

[Takanori MATSUURA]

(In reply to Serban Stanca [:SerbanS] from comment #12)

https://hg.mozilla.org/mozilla-central/rev/8bb3a79f8b7e
https://hg.mozilla.org/mozilla-central/rev/1eeed5905a2f
https://hg.mozilla.org/mozilla-central/rev/0a5557cbb59a
https://hg.mozilla.org/mozilla-central/rev/204ed2f3fce9

Backed out by https://hg.mozilla.org/mozilla-central/rev/b0af2af08084

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1437f9b957ce
Update wast to support table64. r=rhunt,supply-chain-reviewers
https://hg.mozilla.org/integration/autoland/rev/f5d15d3cf547
Implement table64 functionality. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/cb78cd79d789
Update spec test harness error handling. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/7effd2716900
Update memory64 spec tests. r=rhunt

Comment 15

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/1437f9b957ce
https://hg.mozilla.org/mozilla-central/rev/f5d15d3cf547
https://hg.mozilla.org/mozilla-central/rev/cb78cd79d789
https://hg.mozilla.org/mozilla-central/rev/7effd2716900