1917175 - Browser considers Saraiki (skr) as LTR rather than RTL

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P1)

Description

[Eemeli Aro [:eemeli]]

The earlier update of the unic-langid and unic-langid-impl crates from 0.9.1 to 0.9.5 made in bug 1869512 was rolled back in patch D213777 for bug 1893643.

The consequence of the rollback is that we use CLDR 37 rather than CLDR 44 data for language directionality, and the earlier had Saraiki incorrectly coded as LTR rather than RTL.

Ben, it looks like this may have been accidental?

Comment 1

[Francesco Lodolo [:flod]]

[Tracking Requested - why for this release]: while we have few users for Saraiki (it was introduced in 128), this is showing the browser with wrong text direction.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1893643

Comment 3

[Pascal Chevrel:pascalc]

Potentially, we could uplift a fix in the planned dot release (if it lands on nightly and beta first)

Comment 4

[Ben Visness [:bvisness]]

Yes, this was accidental. I only meant to update our wasm-tools packages for internal testing. I think I just carried over an unrelated update while rebasing. Apologies for that.

Comment 5

[Eemeli Aro [:eemeli]]

Attachment: Bug 1917175 - Re-update unic-langid and unic-langid-impl to 0.9.5. r?bvisness!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f29692950ab
Re-update unic-langid and unic-langid-impl to 0.9.5. r=bvisness

Comment 7

[Eemeli Aro [:eemeli]]

Attachment: Bug 1917175 - Re-update unic-langid and unic-langid-impl to 0.9.5. r?bvisness!

Original Revision: https://phabricator.services.mozilla.com/D221430

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users of the Saraiki localization will have the browser render as left-to-right instead of right-to-left
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: In language settings, change the UI language to Saraiki (سرائیکی). Note that a reload is required as it should be for a LTR -> RTL switch, and after a restart layout switches to be RTL.
• Risk associated with taking this patch: low
• Explanation of risk level: The change was already included earlier, but was accidentally rolled back
• String changes made/needed: no
• Is Android affected?: no

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4f29692950ab

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Release approval also.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/705143bac476

Comment 12

[Pascal Chevrel:pascalc]

Please note that tomorrow is the deadline to nominate this fix for the planned 130 dot release.

Comment 13

[Francesco Lodolo [:flod]]

Attachment: Bug 1917175 - Re-update unic-langid and unic-langid-impl to 0.9.5. r?bvisness!

Original Revision: https://phabricator.services.mozilla.com/D221430

Comment 14

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Users of the Saraiki localization will have the browser render as left-to-right instead of right-to-left
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: In language settings, change the UI language to Saraiki (سرائیکی). Note that a reload is required as it should be for a LTR -> RTL switch, and after a restart layout switches to be RTL.
• Risk associated with taking this patch: low
• Explanation of risk level: The change was already included in fx128, but was accidentally rolled back by mistake in unrelated patch
• String changes made/needed: None
• Is Android affected?: no

Comment 15

[Pascal Chevrel:pascalc]

This fix will be included in our planned 130 dot release, thanks.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/fa3a9bd11d39

Comment 17

[Alexandru Trif, Desktop Test Engineering [:atrif]]

I have reproduced the issue with Firefox 130.0 (20240829075237) and 132.0a1 (2024-09-06) on Windows 10x64. After changing the language to Saraiki (سرائیکی) as stated in comment 14 the UI layout will not change to RTL even after a restart.
The issue is verified fixed with Firefox 130.0.1, 131.0b7, and 132.0a1 (2024-09-16) on Windows 10x64, macOS 12, and Ubuntu 24. After changing the language to Saraiki (سرائیکی) the UI will change to RTL and will stay as expected after a restart.