1893666 - Add new properties to nsToolkitProfile to support selectable profiles

Status: NEW

(Toolkit :: Startup and Profile System, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

To support starting up into a selectable profile instead of the existing named profiles, add optional properties to nsToolkitProfile: the group DB path, a flag to show the new profile selector at startup, and a flag to make a profile the default profile. (Any other properties to add? Double check the docs.)

These will need to be written out to profiles.ini, so there may be changes needed in nsToolkitProfileService to map these properties to the profile entry in installs.ini.

Be sure to gate these changes on the build-time flag defined in bug 1893315.

Best reference doc is probably the profile selector architecture doc, https://docs.google.com/document/d/1PP4NjlOBmwNJP9emu1Bk5LBk_LcD284xMZZ8gG11-S0/edit#heading=h.rd74ekz7fx9v.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1893666 Part 1 - make the nsToolkitProfile rootDir writable. r?mossop!,niklas

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1893666 Part 2 - Add profile group ID to profiles.ini and nsToolkitProfile. r?mossop!,niklas

Still quite WIP but I'm out of time for the night and feedback would be
helpful.

• Add support for a GroupDB key to the profiles.ini section for a
  profile.
• Map the GroupDB key to a groupDatabasePath property on
  nsToolkitProfile (TODO find a better, more concise name).
• Add a first simple test to verify that setting this on the profile
  instance gets serialized to profiles.ini as expected.

My main open questions are around relative descriptors and whether we
want to constrain the setter beyond just accepting an nsIFile pointer.
Some other C++ syntax questions called out as TODOs inline. Also some
printf() calls and comments to be removed before landing.