1893714 - Firefox logo on the about:newtab is hidden from the assistive technology

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Firefox logo is not exposed to the assistive technology

The Firefox brand logo is not exposed to the assistive technology, while it does provide meaningful information for the user which is not duplicated in text elsewhere on the page.

Provide a textual alternative to the image, i.e. Firefox - this would ensure screen reader users who cannot see or understand the screen visually would still be provided the same level of assurance and transparency where this whole page is coming from (from the Fx).

I.e. <div class="logo-and-worldmark"> could get role="image" aria-label="Firefox" to achieve that.

Note that this bug is a high severity access-S3 because the lack of the brand information exposure may affect the trust in the content for a screen reader user.

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 1893714 - Add aria-label to Firefox logo on HNT r?#home-newtab-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a02bd148663b
Add aria-label to Firefox logo on HNT r=home-newtab-reviewers,fluent-reviewers,nbarrett

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a02bd148663b

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

@ayeddi @maxx

I noticed that the landed patch used -brand-full-name as the accessible name, which is "Mozilla Firefox", rather than just "Firefox", which is the actual visible content of the firefox-wordmark.svg file.

Also, since the image itself is not localised, the current implementation is relying on the aria-label being exactly the same in all localisations. I believe it currently is for the official release since the Firefox default brand name does not vary between locales, but it seems unnecessary, and may not be true for non-official releases.

Would it be more accurate to make the accessible name non-localised with lang="en" on the element? And have the en-US text of the firefox-wordmark.svg file set in a non-localised Fluent file in the corresponding browser/branding directory?

Comment 6

[Anna Yeddi [:ayeddi]]

(In reply to Henry Wilkes (they/them) [:henry-x] from comment #5)

@ayeddi @maxx

I noticed that the landed patch used -brand-full-name as the accessible name, which is "Mozilla Firefox", rather than just "Firefox", which is the actual visible content of the firefox-wordmark.svg file.

Also, since the image itself is not localised, the current implementation is relying on the aria-label being exactly the same in all localisations. I believe it currently is for the official release since the Firefox default brand name does not vary between locales, but it seems unnecessary, and may not be true for non-official releases.

Would it be more accurate to make the accessible name non-localised with lang="en" on the element? And have the en-US text of the firefox-wordmark.svg file set in a non-localised Fluent file in the corresponding browser/branding directory?

Thank you for bringing it up, @Henry-x! I did not think about the logo's label localization before - seems that it could save our amazing L10n community some work too.

I think, assistive technologies like screen readers should be able to announce English text when it’s marked as such (i.e. when non-Latin-based writing system is used). And removing the “Mozilla” from the alt text would be appropriate too (as you mentioned, the on-screen text is only “Firefox”), but also the logo is kind of for Mozilla Firefox. I do not really have any specific recommendations for the accessibility side of things.

Maybe we’d need to check with the L10n team what do they think about the use of lang in this case. AFAIK, “aria-label” will also be translated by the Firefox when the bug 1944944 ships. I'd leave the decision to @Maxx.

Comment 7

[Maxx Crawford [:maxx]]

Tagging Bryan to get his take. I confirmed through each version (including Nightly), it's always the same "Firefox" (even though the logo - not the wordmark - does change.

Bryan - Should we change this from -brand-full-name to -brand-product-name.

Comment 8

[Bryan Olsson [:bolsson]]

Thanks Maxx - yeah, I believe -brand-product-name seems to make sense here and aligns with how we use it across the project.

Comment 9

[Maxx Crawford [:maxx]]

Re-opening bug to get the fix added. Thanks everyone!

Comment 10

[Maxx Crawford [:maxx]]

Opening a regression bug for better tracking.