1893732 - Save to Pocket buttons on the about:newtab cards are missing the Pocket in their accessible name

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Accessibility Inspector highlighting `Save to Pocket` button's accessible name

STR:

1. Ensure a screen reader is running
2. Using keyboard alone, navigate to one of Save to Pocket buttons on the activity stream cards in the Thought-provoking stories section
3. Observe the announcement

Current:

1. The Save to Pocket buttons do not indicate to a screen reader user that the Pocket is involved, it is only announced as Save

Expected:

1. The button's visual label is the same as the accessible/programmatic one - i.e. Save to Pocket or Pocket: Save, etc. - ensure the Pocket is mentioned since it is included in the visual label and provides important information of the function of the button.

Note: since there is an on-screen image, it is possible to follow the Informative images guide to provide its with an textual alternative, which would be then automatically included in the accessible name calculation for the button.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:amy, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 1893732 - Add label to "Save to Pocket" button for extra context r?#home-newtab-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ce05cc50608
Add label to "Save to Pocket" button for extra context r=home-newtab-reviewers,nbarrett,fluent-reviewers

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7ce05cc50608