1893846 - Potential bug in SessionPrioritizationMiddleware.kt

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[jackyzy823]

1. Since the introduction of telemetry in bug 1820211, the session priority would be reset to DEFAULT when the activity is paused (like switching to background) , because checkForFormData will cause UpdateHasFormDataAction to be dispatched when getting result from GeckoView side.

2. There is a chance that previousHighestPriorityTabId is equivalent to selectedTabId , but selectedTabId's current session priority is DEFAULT. If previousHighestPriorityTabId not changed after, then this tab will never be set to HIGH again.

   So after everytime updateSessionPriority(DEFAULT) is called , we should reset previousHighestPriorityTabId to "" if previousHighestPriorityTabId == selectedTabId

Comment 1

[jackyzy823]

Attachment: Bug 1893846 - Don't dispatch UpdateHasFormDataAction after PauseAction and reset previousHighestPriorityTabId when UnlinkEngineSessionAction. r?#android-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a73209fffee
Don't dispatch UpdateHasFormDataAction after PauseAction and reset previousHighestPriorityTabId when UnlinkEngineSessionAction. r=android-reviewers,boek

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8a73209fffee