1893945 - Changing new tab wallpaper does not update the credit links until page is reloaded.

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Kestrel]

Attachment: Credit link for mountain wallpaper still showing link for red panda

STR:

1. Set browser.newtabpage.activity-stream.newtabWallpapers.enabled = true.
2. Change the new tab wallpaper image.
3. Scroll to the bottom of the page and hover the cursor over the "Photo by" links.

The text for the photo credit changes but the link destinations are for the last wallpaper before the page was reloaded.

Comment 1

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1893945 - fix wallpaper attribution after wallpaper selection r=#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06676b9476d8
fix wallpaper attribution after wallpaper selection r=home-newtab-reviewers,thecount

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/06676b9476d8

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nbarrett, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 9402046 [details]
Bug 1893945 - fix wallpaper attribution after wallpaper selection r=#home-newtab-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Wallpaper attribution at the bottom of newtab doesn't properly update if a user changes the wallpaper
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Set browser.newtabpage.activity-stream.newtabWallpapers.enabled to true

2. Open the newtab personalize menu.
3. Select a wallpaper.
4. Scroll to the bottom of newtab, and check the links under the wallpaper attribution.
5. Set another wallpaper.
6. Scroll to the bottom of newtab again, and the the links under the wallpaper attribution.
   expected: Should match the current wallpaper.
   actual: Still shows the links for the previous wallpaper set on step 3.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's 1 line
• String changes made/needed: None
• Is Android affected?: No

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Firefox Nightly 128.0a1 (Build ID 20240517092152) on Windows 10, macOS 14.4.1, and Ubuntu 22.04.

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9402046 [details]
Bug 1893945 - fix wallpaper attribution after wallpaper selection r=#home-newtab-reviewers

Approved for 127 beta 4, thanks.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8a9220b01767

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/8a9220b01767