1893958 - Language unsupported error panel has incorrect UI for the disabled Translate button

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Daniel Bodea [:danibodea]]

Note

• The disabled Translate button on the unsupported language error panel is light gray instead of light blue.

Found in

• Nightly v127.0a1

Affected versions

• Nightly v127.0a1

Tested platforms

• Affected platforms: Windows 10, MacOS 11
• Unaffected platforms: -

Steps to reproduce

1. Load a webpage that is displayed in a language different than the browser's AND unsupported by Fx Translations.
   Ex. Chinese Wikipedia webpage
2. Select a random string of text and open the context menu.
3. Select the Translate option.

Expected result

• The Translate button is light blue.

Actual result

• The Translate button is light gray.

Regression range

• Not a regression.

Additional notes

• The enabled button is correctly displayed as blue.

Comment 1

[Daniel Bodea [:danibodea]]

Attachment: ST - Translate button color.png

Comment 2

[Erik Nordin [:nordzilla]]

I believe that fixing Bug 1893345 will fix this bug as well, because the core issue of Bug 1893345 is that the buttons are currently one level of indirection down in the markup from the moz-button-group element, and they need to be direct descendants for the moz-button-group to operate on the buttons properly.

I will check back on this once I fix Bug 1893345 but we're still waiting for final confirmation from the Acorn group about how it should look on Windows.

Comment 3

[Daniel Bodea [:danibodea]]

This issue appears to be fixed by the changes in bug 1893345. Is there anything else that needs to be addressed after the UI confirmation mentioned in comment 2? If not, can you close it? Thanks.