189415 - treat Junk folder like special folder

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

treat Junk folder like special folder

make it so

1) it's at the top, with the other special folders, with a different icon
2) can't be renamed
3) can't be deleted

fix in hand.

Comment 1

[(not reading, please use [e-mail] instead)]

accepting

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: theme part

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: mailnews part of the patch

Comment 4

[(not reading, please use [e-mail] instead)]

fixed

Comment 5

[(not reading, please use [e-mail] instead)]

there are going to be some spin off bugs on this, similar to those bugs that we 
have for other special folders.

I have some work to do properly handle when the user manually choose a folder 
to be the junk folder.

and there are some other issues.

Comment 6

[Gilles Dumortier]

Be sure also to deactivate the navigation with the N short-key because we don't
have to read inside this special folder.

Comment 7

[Quinn Yost (mythdraug)]

I think this checkin might be causing some unexpected changes to the
ordering of message folders.

I have 5 accounts beyond "Local Folders".  I have at some point had
Junk mail filtering enabled for the first two.  Looking through my
accounts, they do not list the same folders in the same sequence anymore..
(quoted folders are ones I created).

1) Inbox, Drafts, Templates, Sent, Junk, Trash, "Archive"
2) Drafts, Inbox, Junk (w/o special Icon), Sent, "Received", Trash, Templates
3) Inbox, Drafts, Templates, Sent, Trash
4) Inbox, Drafts, Templates, Sent, Trash
5) Drafts, Inbox, "Safe", Sent, Trash, "File Cabinet", "JunkMail", Templates,
Unsent Messages


I'll spin this out to a new bug if you prefer.

Comment 8

[esther]

Using trunk build 20030121 on winxp
Testing automatically creating the Junk mail folder when turning on Junk mail
controls on Windows only at this time.  
New Profile one mail account:
IMAP-Creates the folder immediately but doesn't mark it as special folder until
you ping the server by collapse/expand the server or Get Msg.  OK
POP- Creates the folder immediately and marks it special.  OK
WebIMAP - Same as IMAP.  OK
AOLIMAP - Gives error that it can't create the folder - expected  Maybe we
should default to Local folder for this case, I'll write up a bug.  
New Profile 3 accounts IMAP, POP & POP:
All accounts created the Junk folders as mentioned in single cases above.  OK,
for all accounts and special folders are listed in the same order for each
account after server has been pinged (Inbox,Drafts,Templates,Sent,Junk,Trash) 
  
I have some spin off bugs regarding setting up the same IMAP account in a new
profile.  

This bug is verified/fixed. 
Quinn, what platform are you using, are the accounts IMAP or POP and have you
exited and relaunched to see if the folders are listed correctly after an exit?

Spinoff bugs 190349 & 190354