1894211 - [wpt-sync] Sync PR 45986 - PrePaint: Still use fragmentainer index for pagination.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45986 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45986
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

PrePaint: Still use fragmentainer index for pagination.

https://crrev.com/c/5453623 (Plumbing for new pagination fragment
structure) moved some pagination pre-paint logic into a separate
function, but left the fragmentainer index counter behind (in the belief
that it wouldn't matter, since it was named inner_fragmentainer_idx and
what not). This was bad, because this meant that FragmentData's
FragmentID wouldn't be updated. FragmentID isn't used for a whole lot of
things anymore, but CullRectUpdater still needs it in order to match
fragments of one paint layer with fragments in the parent layer. If all
IDs were 0, all child fragments would match with all parent fragments,
so that all fragments would get non-empty cull rects, even if they
belonged on different pages. This in turn would cause us to paint the
same object several times, once for each fragment. All but one of its
fragments would get clipped by the page area, but certain types, such as
SVG apparently, got upset by this.

Walk page containers as a separate loop. There's too little in common
with multicol.

Bug: 337791467
Change-Id: Id2f5543e2c415cae75ad4621969e3e48358ad5ac
Reviewed-on: https://chromium-review.googlesource.com/5501140
WPT-Export-Revision: aceb20172464de109d390985135453bbdf84a188

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=268ad43027f22db407fbc051c069a4088a270188

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5d058e289bc
[wpt PR 45986] - PrePaint: Still use fragmentainer index for pagination., a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d5d058e289bc