1894214 - Quick Filter and Mark All Read (Shift + C) marks all emails as read in a folder (not just the filtered one)

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[kralicek]

Steps to reproduce:

Let's filter some emails in a folder with more unread emails. (The filter doesn't contain all the unread messages, just some of them.)

Actual results:

However, the Mark All Read (Shift + C) will mark all messages in the folder as read.

Expected results:

Only mark as read messages from the Quick Filter.
In Thunderbird 102 this works as expected.

Comment 1

[Bogomil Shopov[:Bogomil]]

i can reproduce it on 127.0a1 (2024-05-01) under Linux. Not sure what's the right behavior here.

Comment 2

[kralicek]

Hello, is there anything I can do for this request?

Comment 3

[Wayne Mery (:wsmwk)]

In Thunderbird 102 this works as expected.

Ramona can you find the regression?

Comment 4

[Ramona Gavrilescu]

Hello,

I have managed to find a regression range

It would seem the last good build was from 2023-11-01 and the first bad build was from 2023-11-02.

The bisection returned:

2024-07-26T13:42:41.388000: INFO : Narrowed integration regression window from [2a35a89b, ee06a3ed] (3 builds) to [2a35a89b, 0a75f14e] (2 builds) (~1 steps left)
2024-07-26T13:42:41.409000: DEBUG : Starting merge handling...
2024-07-26T13:42:41.409000: DEBUG : Using url: https://hg.mozilla.org/comm-central/json-pushes?changeset=0a75f14e0406a7a6f0553cfe22ea1801eaca8888&full=1
2024-07-26T13:42:41.409000: DEBUG : redo: attempt 1/3
2024-07-26T13:42:41.409000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/comm-central/json-pushes?changeset=0a75f14e0406a7a6f0553cfe22ea1801eaca8888&full=1',), kwargs: {}, attempt #1
2024-07-26T13:42:41.453000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2024-07-26T13:42:42.269000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /comm-central/json-pushes?changeset=0a75f14e0406a7a6f0553cfe22ea1801eaca8888&full=1 HTTP/1.1" 200 None
2024-07-26T13:42:42.333000: DEBUG : Found commit message:
Bug 1862393 - Update ignore list in browser_parsable_css and add symlink fix to head file. r=mkmelin

Differential Revision: https://phabricator.services.mozilla.com/D192459

2024-07-26T13:42:42.334000: DEBUG : Did not find a branch, checking all integration branches
2024-07-26T13:42:42.336000: INFO : The bisection is done.
2024-07-26T13:42:42.338000: INFO : Stopped

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1894214 - Fix "Mark All Read" for Quick Filter and virtual folders. r=#thunderbird-reviewers

This essentially backs out the changeset for bug 519687 to fix the regression regarding Quick
Filter and adds the functionality for multi-folder search views.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/52bfd3141632
Fix "Mark All Read" for Quick Filter and virtual folders. r=mkmelin

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9417632 [details]
Bug 1894214 - Fix "Mark All Read" for Quick Filter and virtual folders. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128 - not been through beta, but been on daily for several weeks and it returns previous functionality to avoid dataloss

vlad, ramona can you verify correct functionality?

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 128.2.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/d51c75b154f7

Comment 9

[Ramona Gavrilescu]

Confirming this issue as verified fix for 128.2.0esr(20240829182308) on Win 11.