1894337 - Replace --in-content-page-color value with design token

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Tim Giles [:tgiles]]

Something that we noticed during Bug 1858998 is that changing the color-scheme in Storybook would cause some element not to update correctly. This appears to be because of variables in common-shared.css not utilizing the new design tokens. --in-content-page-color is used six times in common-shared and is a good candidate to replace the value with the design token equivalent.

Comment 1

[Stuart Colville [:muffinresearch]]

Need input to have the right replacement token to move forward.

Comment 2

[Jules Simplicio [:jules]]

Hey all, this in-content page variable should now be --background-color-canvas

Comment 3

[Catherine Meade]

We're going to use --text-color instead, and I have also created https://bugzilla.mozilla.org/show_bug.cgi?id=1980414 to consolidate the background properties.

Comment 4

[Catherine Meade]

Attachment: Bug 1894337 - Replace `--in-content*` color values with design token r?#reusable-components-reviewers

Changed

• --in-content-page-color references now use --text-color
• --in-content-text-color references now use --text-color

Removed

• --in-content-page-color references
• --in-content-text-color references

Comment 5

[Jules Simplicio [:jules]]

Ope my bad, I must've assumed it was page-background not the color. Thanks for catching this Catherine :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6d508c96275b
https://hg.mozilla.org/integration/autoland/rev/05931e75028a
Replace `--in-content*` color values with design token r=reusable-components-reviewers,mtigley,extension-reviewers,settings-reviewers,desktop-theme-reviewers,credential-management-reviewers,webrtc-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,omc-reviewers,firefox-ai-ml-reviewers,toolkit-telemetry-reviewers,akulyk,nchevobbe,hjones,gregtatum,mjf,rpl,mviar

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/05931e75028a