Closed Bug 1894357 Opened 5 months ago Closed 5 months ago

[wpt-sync] Sync PR 45993 - Revert "[css-anchor-position] First step of scroll adjustment with overflow:hidden"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox127 fixed)

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45993 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45993
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Revert "[css-anchor-position] First step of scroll adjustment with overflow:hidden"

This reverts commit b7083805b9cf8a166f46624b98bef4ea5a72fe06.

Reason for revert: The CL caused crbug.com/337909142.

On composited scrolls, when we update the main thread scroll offset,
we normally omit commit, and the changed default adjustment is not
committed, and the anchor adjustment will be incorrect if anything
causes (e.g. a non-scrollable scroll container without a scroll node)
fallback to the default adjustment.

Original change's description:

[css-anchor-position] First step of scroll adjustment with overflow:hidden

This implements fail-safe for missing nodes referenced from
adjustment ids of an anchored transform node. The case may happen

  • for overflow:hidden scrollers for which we don't create scroll nodes
    for now;
  • for adjustment containers that are not painted due to cull rect,
    etc.

We'll use the main-thread calculated adjustment when any node is
missing. This is not perfect (e.g. position of anchored may lag behind
composited scrolling) but is better than not being anchored or jumping
between anchored and not anchored.

We may implement better solutions and decide whether to remove this
fail-safe (or convert it to CHECK) in the future.

Bug: 332331854
Change-Id: I9b9121a173fdc52eeaf2987f3886155f3ea773bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455174
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Commit-Queue: Xianzhu Wang \<wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1288314}

Bug: 332331854, 337909142
Change-Id: I5528aeee1ace8dfff0d6cf299941ede6a4961a3b

Reviewed-on: https://chromium-review.googlesource.com/5503090
WPT-Export-Revision: a5dd6c24bd3dd016f0c5f173eff5fe539c47101b

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b9b6671d4e2 [wpt PR 45993] - Revert "[css-anchor-position] First step of scroll adjustment with overflow:hidden", a=testonly

https://hg.mozilla.org/mozilla-central/rev/6b9b6671d4e2

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.