1894364 - [wpt-sync] Sync PR 45995 - Fix moveBefore() DHECK failure

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45995 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45995
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Fix moveBefore() DHECK failure

FlatTreeParentChanged() was originally intended for slot re-assignments.
The DCHECK for nodes being slottable failed for moveBefore() for comment
nodes, for instance. Separate out the common FlatTreeParentChanged()
method and add DCHECKs to a new ParentSlotChanged() instead.

Bug: 338071841
Change-Id: I18dd20e000c7d1ef9cdf6f5bb4034dd651839778
Reviewed-on: https://chromium-review.googlesource.com/5503469
WPT-Export-Revision: 06b4ad76f0b4e8d55b0e3e496b39d67b587f6733

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=96121b4191adf6fd2d0557cbfb43323299afdd62

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bd7225c9693
[wpt PR 45995] - Fix moveBefore() DHECK failure, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9bd7225c9693