1894433 - [wpt-sync] Sync PR 46001 - Use hasCondition() or hasSource() to confirm their existence

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46001 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46001
Details from upstream follow.

Yoshisato Yanagisawa <[e-mail]> wrote:

Use hasCondition() or hasSource() to confirm their existence

If the rule without condition or source is used, it causes the renderer
crash because the IDL expect condition() and source() is used only if
they are set.

Change-Id: I34b8f76b1cf4f245b7b096db120176134d72b6c8
Reviewed-on: https://chromium-review.googlesource.com/5504213
WPT-Export-Revision: 67bd352b54d340e506ea00c92d81377ef530b501

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f13370a4311eecbcd320e2426877e34d416da77a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
FAIL : 5

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /service-workers/service-worker/tentative/static-router/static-router-invalid-rules.https.html [wpt.fyi]
  • addRoutes should raise for invalid request method.: FAIL (Safari: FAIL)
  • addRoutes should raise if or condition exceeds the depth limit: FAIL (Safari: FAIL)
  • addRoutes should raise if the number of router rules exceeds the length limit: FAIL (Safari: FAIL)
  • addRoutes should raise if the conditon does not exist in the rule: FAIL (Safari: FAIL)
  • addRoutes should raise if the source does not exiswt in the rule: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/897e51f93aaa
[wpt PR 46001] - Use hasCondition() or hasSource() to confirm their existence, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3b5fb92037bf
[wpt PR 46001] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/897e51f93aaa
https://hg.mozilla.org/mozilla-central/rev/3b5fb92037bf