Open Bug 1894479 Opened 10 months ago Updated 10 months ago

Make test_moz_button less prone to false negatives

Categories

(Toolkit :: UI Widgets, task)

Product:
Toolkit
Component:
UI Widgets
Type:
task

Tracking

()

People

(Reporter: hjones, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

While working through bug 1893661 I realized that certain CSS vars used by moz-button (--button-text-color and --button-icon-color) have the same value in our built in dark theme, but different values in the light theme. This introduces a subtle footgun - because test_moz_button is focused on verifying CSS values it's possible the tests will pass for you locally if you're using a dark theme at the OS level, then fail when running in automation.

To get around this issue of potentially hidden failures we should either:

  • always ensure the default light theme is active when running the tests
  • run all the checks with both a light theme and a dark theme
You need to log in before you can comment on or make changes to this bug.