1894484 - Try-again button should have visible focus when an error occurs

Status: RESOLVED FIXED

(Firefox :: Translations, defect, P3)

Description

[Erik Nordin [:nordzilla]]

Description

We need to sure that the try-again button has visible focus when it becomes the active element during a panel error state, both to provide a better general user experience, and for a11y customers who would benefit from the extra visual signaling.

---

Steps to implement

• Ensure that { focusVisible: true } is always passed when focusing the try-again button.

---

Tests to implement

• Ensure that the try-again button is the active element in these scenarios.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1894484 - Ensure try-again button has visible focus when an error occurs r=#translations-reviewers!

Ensures that the try-again button receives a focus outline
any time an error state occurs in the SelectTranslationsPanel,
to more clearly indicate a possible next action to take.

Depends on D209091

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:nordzilla, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Erik Nordin [:nordzilla]]

Bumping to match A11y severity.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/033d5c8c3f8a
Ensure try-again button has visible focus when an error occurs r=translations-reviewers,gregtatum

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_translations_select_panel_translation_failure_after_unsupported_language.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/translations/tests/browser/browser_translations_select_panel_translation_failure_after_unsupported_language.js | The element 'select-translations-panel-translate-button' should have focus. - Got [object XULElement], expected [object XULElement]

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/033d5c8c3f8a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0be27e9af0bb
Ensure try-again button has visible focus when an error occurs r=translations-reviewers,gregtatum

Comment 8

[Erik Nordin [:nordzilla]]

:SerbanS, same question here. I'm not sure why this was marked as RESOLVED when it was backed out. I'm changing this to REOPENED and leaving you a NI.

Comment 9

[Serban Stanca [:SerbanS]]

Thank you!

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0be27e9af0bb