1894618 - c-c perma xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_runtime_getContexts.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=456607109&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HM9-tYY3QCecnmV5X5cJbQ/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin]]

The test was added in bug 1875480

Comment 2

[Magnus Melin [:mkmelin]]

[task 2024-05-02T05:14:37.652Z] 05:14:37     INFO -  TEST-PASS | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_runtime_getContexts.js | test_runtime_getContexts - [test_runtime_getContexts : 100] Got the expected error message - "Error: Incorrect argument types for runtime.getContexts." == "Error: Incorrect argument types for runtime.getContexts."
[task 2024-05-02T05:14:37.652Z] 05:14:37     INFO -  "Test runtime.getContext resolved when called with an empty filter parameter"
[task 2024-05-02T05:14:37.652Z] 05:14:37     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "tabTracker.getBrowserDataForContext is not a function" {file: "resource://gre/modules/ExtensionParent.sys.mjs" line: 786}]
[task 2024-05-02T05:14:37.652Z] 05:14:37     INFO -  toExtensionContext@resource://gre/modules/ExtensionParent.sys.mjs:786:44
[task 2024-05-02T05:14:37.653Z] 05:14:37     INFO -  getContexts@chrome://extensions/content/parent/ext-runtime.js:151:28

Comment 3

[Magnus Melin [:mkmelin]]

https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/toolkit/components/extensions/ExtensionParent.sys.mjs#786 -- getBrowserDataForContext is from ext-browser.js. Thunderbird doesn't have an ext-browser.js

John, what do you suggest?

Comment 4

[John Bieling (:TbSync)]

We have to add it to our own TabTracker:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mail.js#626

But at the moment I do not even know what this is supposed to return. I can look at this tomorrow.

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to John Bieling (:TbSync) from comment #4)

We have to add it to our own TabTracker:
https://searchfox.org/comm-central/source/mail/components/extensions/parent/ext-mail.js#626

But at the moment I do not even know what this is supposed to return. I can look at this tomorrow.

I confirm that to be the case: Thunderbird tabTracker subclass will have to implement the getBrowserDataForContext as we did for Firefox Desktop in ext-browser.js and for Fenix in ext-android.js of the original patch.

I guess for tabs and background the implementation for Thunderbird may likely match the one that we have for Firefox desktop (given that in that case we just use the pre-existing getBrowserData method internally), for popup and sidebar I'm not sure (it may be the same as Firefox Desktop if the browser elements where the popup and sidebar extension pages are loaded are at the same level of nesting from the chrome privileged window document as the ones we use in Firefox Desktop).

Feel free to ping me here or on phabricator if turns out that isn't the case and I may be able to help to determine how the corresponding implementation for Thunderbird may have to look like.

Comment 6

[Intermittent Failures Robot]

53 failures in 868 pushes (0.061 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 40
• try-comm-central: 13

Platform and build breakdown:

• windows11-64-2009-qr: 13
  • opt: 8
  • debug: 5
• linux1804-64-qr: 13
  • opt: 7
  • debug: 6
• windows11-32-2009-shippable-qr: 3
  • opt: 3
• windows11-64-2009-shippable-qr: 4
  • opt: 4
• linux1804-64-shippable-qr: 3
  • opt: 3
• linux1804-64-ccov-qr: 3
  • opt: 3
• macosx1015-64-shippable-qr: 3
  • opt: 3
• macosx1015-64-qr: 4
  • opt: 4
• windows11-32-2009-qr: 6
  • debug: 3
  • opt: 3
• windows11-64-2009-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1894618&startday=2024-05-02&endday=2024-05-02&tree=all

Comment 7

[Intermittent Failures Robot]

49 failures in 781 pushes (0.063 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 26
• try-comm-central: 23

Platform and build breakdown:

• linux1804-64-qr: 14
  • opt: 6
  • debug: 8
• windows11-32-2009-qr: 7
  • opt: 5
  • debug: 2
• macosx1015-64-qr: 4
  • opt: 3
  • debug: 1
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows11-64-2009-qr: 12
  • debug: 6
  • opt: 6
• windows11-64-2009-shippable-qr: 4
  • opt: 4
• linux1804-64-ccov-qr: 2
  • opt: 2
• windows11-64-2009-ccov-qr: 1
  • opt: 1
• windows11-32-2009-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1894618&startday=2024-05-03&endday=2024-05-03&tree=all

Comment 8

[Intermittent Failures Robot]

111 failures in 4059 pushes (0.027 failures/push) were associated with this bug in the last 7 days.

This is the #4 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 75
• try-comm-central: 36

Platform and build breakdown:

• macosx1015-64-qr: 9
  • opt: 8
  • debug: 1
• linux1804-64-qr: 29
  • opt: 14
  • debug: 15
• windows11-64-2009-qr: 28
  • opt: 16
  • debug: 12
• linux1804-64-shippable-qr: 6
  • opt: 6
• windows11-64-2009-shippable-qr: 9
  • opt: 9
• macosx1015-64-shippable-qr: 5
  • opt: 5
• windows11-32-2009-shippable-qr: 5
  • opt: 5
• linux1804-64-ccov-qr: 5
  • opt: 5
• windows11-32-2009-qr: 13
  • debug: 5
  • opt: 8
• windows11-64-2009-ccov-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1894618&startday=2024-04-29&endday=2024-05-05&tree=all

Comment 9

[Intermittent Failures Robot]

23 failures in 747 pushes (0.031 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 23

Platform and build breakdown:

• macosx1015-64-qr: 2
  • opt: 2
• linux1804-64-qr: 4
  • opt: 2
  • debug: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows11-64-2009-qr: 6
  • opt: 4
  • debug: 2
• windows11-32-2009-qr: 4
  • opt: 2
  • debug: 2
• windows11-32-2009-shippable-qr: 2
  • opt: 2
• windows11-64-2009-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1894618&startday=2024-05-06&endday=2024-05-06&tree=all

Comment 10

[John Bieling (:TbSync)]

On it.

Comment 11

[John Bieling (:TbSync)]

@Luca : I have two issues:

1. Currently, we do return a windowId for the contextType: TAB case in the xpcshell test, and not -1, which fails the test. Will try to find a different implementation to make it return -1, but if that does not work, could we exclude the -1 check in the test?

2. We do not (!) see the contextType: TAB case returned by browser.runtime.getContexts({}); in the actual app. In the xpcshell test, the tab is loaded via ExtensionTestUtils.loadContentPage() which creates the browser in ContentPage().

Our own openTab() implementation seems to be missing something, and recvCreateProxyContext is never called. Do you happen to know what magic piece is needed to get it called when the browser is created?

I saw that we do not set initialBrowsingContextGroupId, but even after adding that it does not work.

Comment 12

[Intermittent Failures Robot]

24 failures in 949 pushes (0.025 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• comm-central: 24

Platform and build breakdown:

• linux1804-64-qr: 7
  • opt: 3
  • debug: 4
• macosx1015-64-qr: 3
  • opt: 3
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows11-32-2009-qr: 3
  • opt: 2
  • debug: 1
• macosx1015-64-shippable-qr: 4
  • opt: 4
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• windows11-64-2009-qr: 4
  • opt: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1894618&startday=2024-05-07&endday=2024-05-07&tree=all

Comment 13

[John Bieling (:TbSync)]

I found the answer for #2.

Comment 14

[John Bieling (:TbSync)]

Attachment: Bug 1894618 - Add support for browser.runtime.getContexts(). r=#thunderbird-reviewers

This is adding the required changes to make runtime.getContexts() work
in Thunderbird.

This also adds a mochitest, which is based on this m-c test:
/browser/components/extensions/test/browser/browser_ext_runtime_getContexts.js

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc5cccd4bb60
Add support for browser.runtime.getContexts(). r=mkmelin

Comment 16

[Intermittent Failures Robot]

32 failures in 739 pushes (0.043 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 23
• try-comm-central: 9

Platform and build breakdown:

• linux1804-64-qr: 6
  • opt: 3
  • debug: 3
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows11-64-2009-qr: 10
  • opt: 4
  • debug: 6
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 2
  • opt: 2
• macosx1015-64-qr: 4
  • opt: 3
  • debug: 1
• windows11-32-2009-qr: 5
  • opt: 3
  • debug: 2
• linux1804-64-ccov-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1894618&startday=2024-05-08&endday=2024-05-08&tree=all

Comment 17

[Intermittent Failures Robot]

94 failures in 3649 pushes (0.026 failures/push) were associated with this bug in the last 7 days.

This is the #4 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 85
• try-comm-central: 9

Platform and build breakdown:

• macosx1015-64-qr: 10
  • opt: 9
  • debug: 1
• linux1804-64-qr: 19
  • opt: 9
  • debug: 10
• linux1804-64-shippable-qr: 7
  • opt: 7
• windows11-64-2009-qr: 24
  • opt: 12
  • debug: 12
• windows11-32-2009-qr: 14
  • opt: 8
  • debug: 6
• windows11-32-2009-shippable-qr: 5
  • opt: 5
• windows11-64-2009-shippable-qr: 6
  • opt: 6
• macosx1015-64-shippable-qr: 7
  • opt: 7
• linux1804-64-ccov-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1894618&startday=2024-05-06&endday=2024-05-12&tree=all