1894627 - [wpt-sync] Sync PR 46009 - Fix automatic min size handling of flex and grid items to match the spec.

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46009 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46009
Details from upstream follow.

Emilio Cobos Álvarez <[e-mail]> wrote:

Fix automatic min size handling of flex and grid items to match the spec.

This is a prerequisite to fix issue 40877677 and related issues because
otherwise overflow: clip stops applying min-size: auto.

Both the grid and flex specs mention "scroll container" already, which
means that visible and clip should behave the same:

• https://drafts.csswg.org/css-grid/#min-size-auto
• https://drafts.csswg.org/css-flexbox/#min-size-auto

There's technically a difference between "is scroll container" (what the
spec says) and "overflow is not clip or visible", but the CSSWG already
resolved on just looking at the overflow value in:
https://github.com/w3c/csswg-drafts/issues/7714

Blink was doing the right thing for flex only on replaced elements for
some reason. For grid, most stuff works already due to it using
ComputedStyle::IsScrollContainer, but there was one case missing, which
I added a test for.

Bug: 40877677
Change-Id: I49f57b725ae7feb18250f1e40b3856ec2231bfb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505559
Reviewed-by: John Palmer \<[e-mail]>
Reviewed-by: John Palmer \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Auto-Submit: Emilio Cobos Álvarez \<[e-mail]>
Commit-Queue: Ian Kilpatrick \<[e-mail]>
Reviewed-by: Ian Kilpatrick \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1295163}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=627be1c4611c2766d261444a2f8b80ca7c9bfc6d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1581f0baff8
[wpt PR 46009] - Fix automatic min size handling of flex and grid items to match the spec., a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b1581f0baff8