189496 - Capitalize accesskeys in cache preferences

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[piers]

Capitalize accesskeys in cache preferences:

Me_m_ory Cache
Clear Memory Ca_c_he

Comment 1

[piers]

Attachment: Capitalize accesskeys

Comment 2

[sairuh (rarely reading bugmail)]

out of curiosity, would this capitalize the access key if the access key were in
the middle of a word? that doesn't seem right, since they're usually underlined.
unless i'm misunderstanding what you're doing here...

cc'ing aaronl, the accessibility module owner.

Comment 3

[piers]

I don't quite understand your question, but what i'm doing is ensuring that the
underlined letter is the initial letter instead of some later lowercase
occurance of the same letter.

Comment 4

[sairuh (rarely reading bugmail)]

now it finally dawned on me. thanks a lot! :)

Comment 5

[piers]

Checked in. Marking fixed.

Comment 6

[sairuh (rarely reading bugmail)]

the Cache panel has changed since this was checked in, i believe, overriding
Piers' changes.

i'm going to reopen this in case Piers wishes to check in something for the
latest version of this panel. (but, feel free to re-resolve this and open a new
bug, if you want.)

Comment 7

[piers]

Damn irritating when people overwrite your changes...

thanks for the heads up sairuh.

Comment 8

[mmc]

Attachment: this should do the trick

The attached patch capitalizes (again) the accesskeys. It also fixes the
alignment of a couple of lines.

Comment 9

[mmc]

Attachment: a better one

Don't capitalize the accesskey if in the middle of a word.

Comment 10

[mmc]

Attachment: coolest version ever

Thanks for the clear instructions, this patch should be the right one.

Comment 11

[piers]

Comment on attachment 120849 [details] [diff] [review]
coolest version ever

Looks good to me, over to dean for review :)

Comment 12

[:deanis74]

Comment on attachment 120849 [details] [diff] [review]
coolest version ever

Sure, looks good.

Comment 13

[mmc]

Comment on attachment 120849 [details] [diff] [review]
coolest version ever

Asking for sr=.
Piers: please check this in, when it gets the sr=.

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in
mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-cache.dtd;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-cache.dtd,v
 <--  pref-cache.dtd
new revision: 1.21; previous revision: 1.20
done

Comment 15

[sairuh (rarely reading bugmail)]

hm, i think the change in bug 188956 might've clobbered the checkin intended here.

using today's build (2003.04.23), here are the current access keys for the Cache
pref panel:

_C_ache textfield (capital C)
C_l_ear Cache button (lowercase l)
C_h_oose Folder button (lowercase h)

should this bug be reopened?

Comment 16

[piers]

sairuh, nah, that's the expected behaviour - like it used to be Ca_c_he and is 
now _C_ache.

Comment 17

[sairuh (rarely reading bugmail)]

thanks for the clarification, piers!

okidikes, verifying as fixed.