1895535 - Full browser crash by running new WebTransport(location.href) on MDN and google.com

Status: VERIFIED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

1. Open https://developer.mozilla.org/
2. Run new WebTransport(location.href) on the devtools console

Expected: No crash
Actual: boom!

Crash report: https://crash-stats.mozilla.org/report/index/2325f8ed-6650-4638-a16b-b7bf10240507

Comment 1

[Mayank Bansal]

Tried on two different pages (google.com and some mdn page) and got 2 different crash signatures:
https://crash-stats.mozilla.org/report/index/5245dfe5-6e6f-4b8a-a933-51fd30240507
https://crash-stats.mozilla.org/report/index/7fc7104d-5fda-4f13-94cf-d68960240507

Comment 2

[Mayank Bansal]

Bisection:
Bug 1874464 - Turn on native HTTPS-RR DNS resolver on Nightly r=necko-reviewers,kershaw

Differential Revision: https://phabricator.services.mozilla.com/D198437

Comment 3

[Mayank Bansal]

With network.dns.native_https_query = true , I get hte following regression range:

Bug 1852900 - Use android_res_nquery from libandroid.so to resolve HTTPS records on Android (API level >= 29) r=necko-reviewers,jesup

Depends on D194515

Differential Revision: https://phabricator.services.mozilla.com/D196068

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1874464

:valentin, since you are the author of the regressor, bug 1852900, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Kershaw Chang [:kershaw]]

This is not regressed by bug 1852900.
It's just that the HTTPS record can trigger this crash.

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1895535 - Disable fast fastback and connection coalescing for WebTransport, r=#necko

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/830b2b37dc49
Disable fast fastback and connection coalescing for WebTransport, r=necko-reviewers,valentin

Comment 8

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/830b2b37dc49

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce the crash on a 2024-05-07 Nightly build on Windows 10, using the STR from Comment 0.
Verified as fixed on Firefox Nightly 128.0a1 and Firefox 127.0b4 on Windows 10, macOS 12, Ubuntu 22.