1852900 - Pass HTTPS requests to native resolver thread

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

• Change nsHostResolver code to allow HTTPS record request to be dispatched to native resolver in GetAddrInfo.cpp (maybe that file's name should also be changed)
• Call appropriate system API to resolve HTTPS record. This milestone will only be implemented on one platform. Rest of platforms will follow in Milestone 2.
• Hook up parsing in DNSPacket with data returned by lookup functions. The same code used to parse TRR responses can be used to decode

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1852900 - Factor out DNS HTTPS parsing in DNSPacket r=kershaw

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1852900 - Use DNSQuery_A to resolve HTTPS record on Windows r=#necko

Depends on D193408

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1852900 - Use res_nquery to resolve HTTPS records on Linux r=#necko

Depends on D193656

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 1852900 - Use res_query to resolve HTTPS record on mac r=#necko

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1852900 - Call RecordReason(TRRSkippedReason::TRR_OK) before completing lookup r=kershaw

TRR::OnStopRequest calls RecordReason(TRRSkippedReason::TRR_OK) but this happens
after TRR::ReturnData notifies the resolver and passes on mTRRSkippedReason.
As such, we need to set the reason to TRR_OK before completing.

Not doing this makes the changes in D193656 regress test_trr_telemetry.js
because the TRRSkipReason ends up being TRR_UNSET when we set it on the
record without checking if it's unset.

Depends on D193408

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1852900 - Use android_res_nquery from libandroid.so to resolve HTTPS records on Android (API level >= 29) r=#necko

Depends on D194515

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67e3bcde4813
Factor out DNS HTTPS parsing in DNSPacket r=kershaw,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/cd7d2da58a9b
Call RecordReason(TRRSkippedReason::TRR_OK) before completing lookup r=kershaw,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/222853142bbc
Use DNSQuery_A to resolve HTTPS record on Windows r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/88d71cf5ea62
Use res_nquery to resolve HTTPS records on Linux r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/99907723d4c4
Use res_query to resolve HTTPS record on mac r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/a8de198ef2fb
Use android_res_nquery from libandroid.so to resolve HTTPS records on Android (API level >= 29) r=necko-reviewers,jesup

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/67e3bcde4813
https://hg.mozilla.org/mozilla-central/rev/cd7d2da58a9b
https://hg.mozilla.org/mozilla-central/rev/222853142bbc
https://hg.mozilla.org/mozilla-central/rev/88d71cf5ea62
https://hg.mozilla.org/mozilla-central/rev/99907723d4c4
https://hg.mozilla.org/mozilla-central/rev/a8de198ef2fb