Closed Bug 1895787 Opened 6 months ago Closed 6 months ago

Residual echo on macOS with external speakers

Categories

(Core :: Audio/Video: cubeb, defect, P2)

Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox125 --- unaffected
firefox126 --- unaffected
firefox127 --- disabled
firefox128 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

(Regression)

Details

(Keywords: regression)

Attachments

(7 files)

With platform processing enabled on macOS in bug 1404972 we have some reports of users hearing echo from peers with external speakers. I've done some testing and with builtin speaker and builtin mic I hear no echo, whereas with an external speaker and builtin mic I do hear some echo. It is less echo than you'd get without an AEC but it is constantly present throughout a call, at least as long as there is no real input to the mic of the echoing peer.

Summary: Residual eho on macOS with external speakers → Residual echo on macOS with external speakers
Keywords: leave-open

Currently it leaves a residual echo with some input/output device pairs.

Set release status flags based on info from the regressing bug 1404972

Pushed by dbaker@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/177660503f08 Disable platform processing on macOS. r=webrtc-reviewers,dbaker

Set release status flags based on info from the regressing bug 1404972

I've been testing some more and will note that I have been able to get VPIO into a bad state where it lets echo through. In the system logs when setting up VPIO in this bad state I see a "ref mic" having 0 channels. When not broken it has some actual channels, 6 in my case.

I have had Firefox in a bad state and Safari in a good state at the same time. I also got both into a bad state once after a killall -9 coreaudiod but I haven't been able to reproduce.

A reboot is so far what I have found can get us out of the bad state.

I filed FB13800064 with Apple.

Patches have conflicts so they are updated and applied in separate patches.

Keywords: leave-open

Unbitrot local libcubeb patches after update.

Keywords: leave-open
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d2a56917d964 Update cubeb rust repos to support audio dumping and more. r=cubeb-reviewers,supply-chain-reviewers,padenot https://hg.mozilla.org/integration/autoland/rev/72062912faf8 Update libcubeb. r=cubeb-reviewers,padenot https://hg.mozilla.org/integration/autoland/rev/8b7fbbf0ee1c Update libcubeb patches. r=cubeb-reviewers,padenot https://hg.mozilla.org/integration/autoland/rev/084f645fb060 Apply libcubeb patches. r=cubeb-reviewers,padenot
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6f580829221a Disable voice stream priming and fix a typo in a related pref. r=padenot
Keywords: leave-open
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ea162d71f178 Re-enable platform processing on macOS. r=padenot
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Blocks: 1903002
Regressions: 1903027
Regressions: 1908539
Regressed by: 1904734
No longer regressed by: 1904734
Regressions: 1904734
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: