1903002 - Make voice processing on macOS reliable

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task)

Description

[Andreas Pehrson [:pehrsons]]

Bug 1895787 highlighted an Apple bug where enabling Bypass on a VPIO unit prior to starting effectively makes it stay in bypass for at least one start/stop cycle, no matter what the bypass property is set to later on. This bug is for adjusting the timing of when we change properties on VPIO units so the client of the cubeb backend doesn't have to manage this.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1903002 - Update cubeb-coreaudio-rs to 9ea3d3455d. r#cubeb-reviewers

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1903002 - Enable voice stream priming by default on macOS. r?#cubeb-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cc1aae4583a
Update cubeb-coreaudio-rs to 9ea3d3455d. r#cubeb-reviewers r=cubeb-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/05cd6c5f6bb9
Enable voice stream priming by default on macOS. r=cubeb-reviewers,padenot

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1903002 - Update cubeb-coreaudio-rs to 9ea3d3455d. r#cubeb-reviewers

Original Revision: https://phabricator.services.mozilla.com/D213964

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1903002 - Enable voice stream priming by default on macOS. r?#cubeb-reviewers

Original Revision: https://phabricator.services.mozilla.com/D213965

Comment 6

[Atila Butkovits]

Backed out for causing failures at test_bug384122.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e2f0582a23f92fb2e1758587938f43b577626ba9

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=05cd6c5f6bb9db3da8f4374346724ce370576b31&selectedTaskRun=a9T8vyfjRdWIMXMQiYwnmQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=462893682&repo=autoland&lineNumber=1888

Comment 7

[Andreas Pehrson [:pehrsons]]

This is impossible. This code isn't built on Windows.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a5178d89a8a
Update cubeb-coreaudio-rs to 9ea3d3455d. r#cubeb-reviewers r=cubeb-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/106d1181b256
Enable voice stream priming by default on macOS. r=cubeb-reviewers,padenot

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1a5178d89a8a
https://hg.mozilla.org/mozilla-central/rev/106d1181b256

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b7501126cc06