1895868 - Sidebar should not be visible in popup windows

Status: RESOLVED FIXED

(Firefox :: Sidebar, task)

Description

[Sarah Clements [:sclements]]

The launcher is visible in popup windows, so we should fix this. We might need to take a look at some of the session restore work for persisting sidebar to see if something needs adjustment there - see bug 1885894 (I could be wrong about this and its unrelated, but its something to look into).

Gijs had previously done some digging into legacy sidebar behavior and popup windows and said that you can use keyboard shortcuts, and the View > Sidebar menu on macOSar to access the sidebar. So we should make the sidebar-specific keyboard shortcuts a no-op and disable the sidebar menu.

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1895868 - Sidebar should not be visible in popup windows r=#sidebar-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ab23ba75a11
Sidebar should not be visible in popup windows r=sidebar-reviewers,sessionstore-reviewers,sfoster,kcochrane

Comment 3

[tszentpeteri]

Backed out for causing mochitest failures on browser_history_sidebar.js

• Backout link
• Push with failures
• Failure Log:

[task 2024-06-10T18:43:31.622Z] 18:43:31     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_history_sidebar.js | There is a card for each day. - 2 == 2 - 
[task 2024-06-10T18:43:31.622Z] 18:43:31     INFO - Buffered messages finished
[task 2024-06-10T18:43:31.623Z] 18:43:31     INFO - TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_history_sidebar.js | Card shows the correct number of visits. - 5 == 4 - {"filename":"chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_history_sidebar.js","name":"test_history_cards_created","sourceId":1030,"lineNumber":52,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"handleTask","sourceId":577,"lineNumber":1139,"columnNumber":26,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"_runTaskBasedTest","sourceId":577,"lineNumber":1211,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":577,"lineNumber":1353,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":577,"lineNumber":1128,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":605,"lineNumber":1058,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*handleTask@chrome://mochikit/content/browser-test.js:1139:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"test_history_cards_created@chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_history_sidebar.js:52:12\nasync*handleTask@chrome://mochikit/content/browser-test.js:1139:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1128:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}}
[task 2024-06-10T18:43:31.624Z] 18:43:31     INFO - Stack trace:
[task 2024-06-10T18:43:31.624Z] 18:43:31     INFO - chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_history_sidebar.js:test_history_cards_created:52
[task 2024-06-10T18:43:31.624Z] 18:43:31     INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-06-10T18:43:31.625Z] 18:43:31     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-06-10T18:43:31.625Z] 18:43:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-06-10T18:43:31.625Z] 18:43:31     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1128
[task 2024-06-10T18:43:31.625Z] 18:43:31     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-06-10T18:43:31.626Z] 18:43:31     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_history_sidebar.js | Card shows the correct number of visits. - 4 == 4 - 

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f0d849119b6
Sidebar should not be visible in popup windows r=sidebar-reviewers,sessionstore-reviewers,sfoster,kcochrane

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8f0d849119b6