1896009 - POP3 Inbox scroll position always on mail #2 since 115.10.1

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P1)

Description

[klk745]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:125.0) Gecko/20100101 Firefox/125.0

Steps to reproduce:

115.10.1 introduced a strange bug for me:

1. Start TB or let TB load new e-mails into the inbox.

Actual results:

TB starts with the top scroll position of the inbox set to mail #2.
That way the first/freshest mail is always "invisible" and I need to scroll up.

Expected results:

TB should always scroll to the first mail in the inbox, not the second, like it was the case before 115.10.1.

A research on the web revealed at least three other users with exactly the same problem in this thread on a german TB forum:
https://www.thunderbird-mail.de/forum/thread/94527-ansicht-posteingang/?pageNo=1

Comment 1

[klk745]

Addendum: it seems to only affect POP3 inbox folders. Inbox folders for IMAP accounts scroll to the first mail, as it used to be before this regression. (confirmed by at least two other users in the aforementioned forum)

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce (in TB 115.10):

1. Select a local folder with a bunch of messages sorted by date, descending, without any persisted selection.
2. Select "Local folders" in the folder pane.
3. Select the local folder itself again.
4. Repeat steps 2 and 3.

Expected result:
When the local folder is selected, the topmost message is always scrolled into view.

Actual result:
Every other time the local folder is selected, the the view is not scrolled all the way up to the top.

If you switch back and forth between an IMAP folder and the account it belongs to, the view will scroll to the top, but visibly only after a short delay.

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Regression window

Backing out this revision from comm-esr115 resolves the issue.

Comment 4

[Geoff Lankow (:darktrojan)]

I understand what's happening here. Not sure why it doesn't appear to happen on beta, but there's been several other changes to the message list loading there.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1896009 - Ignore changes to TreeView header height when the view is hidden. r=#thunderbird-reviewers

When the view gets hidden, the resize observers are informed that its height is 0. Consequently
when it becomes unhidden, some calculations are performed using a cached height of 0, before the
resize observers are updated.

When the header itself is hidden, we DO cache a height of 0, because that is the actual height.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8f0d035dc97e
Ignore changes to TreeView header height when the view is hidden. r=mkmelin

Comment 8

[klk745]

Will this be fixed in the 115 ESR series as well?

Comment 9

[Geoff Lankow (:darktrojan)]

Comment on attachment 9401543 [details]
Bug 1896009 - Ignore changes to TreeView header height when the view is hidden. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1883550
User impact if declined: message list starts at the wrong scroll position in some circumstances
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9401543 [details]
Bug 1896009 - Ignore changes to TreeView header height when the view is hidden. r=#thunderbird-reviewers

[Triage Comment]
Approved beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 127.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/729f3f224c29

Comment 12

[Wayne Mery (:wsmwk)]

"The bug is reproducible on 115 by switching between a large local or POP3 folder (newest at top) and the account's root folder. It doesn't really happen on central, so you might want to copy these changes to 115 to test it works."

Are you suggesting we should uplift to 115?

Comment 13

[Geoff Lankow (:darktrojan)]

Comment on attachment 9401543 [details]
Bug 1896009 - Ignore changes to TreeView header height when the view is hidden. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1883550
User impact if declined: message list starts at the wrong scroll position in some circumstances
Testing completed (on c-c, etc.): in 127.0b3
Risk to taking this patch (and alternatives if risky): low

(yes)

Comment 14

[Geoff Lankow (:darktrojan)]

Comment on attachment 9401543 [details]
Bug 1896009 - Ignore changes to TreeView header height when the view is hidden. r=#thunderbird-reviewers

Bah, wrong flag.

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9401543 [details]
Bug 1896009 - Ignore changes to TreeView header height when the view is hidden. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 16

[Daniel Darnell [:dandarnell]]

Thunderbird 115.13.0:
https://hg.mozilla.org/releases/comm-esr115/rev/6664aa91420d