Closed Bug 1896029 Opened 1 year ago Closed 1 year ago

"Translation" entry briefly shows in Settings, up every time you open Settings (and then animates closed before you can read it, because it's disabled-by-default)

Categories

(Firefox for Android :: Translations, defect, P2)

All
Android
defect

Tracking

()

VERIFIED FIXED
128 Branch
Tracking Status
firefox125 --- unaffected
firefox126 --- unaffected
firefox127 + verified
firefox128 --- verified

People

(Reporter: dholbert, Assigned: giorga)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fxdroid][foundation][translations:128])

Attachments

(3 files)

STR:

  1. In Firefox Nightly, open the menu and tap Settings
  2. Watch the bottom of your screen carefully as the Settings page opens.

ACTUAL RESULTS:
There's a mysteriously-instantly-disappearing section at the bottom of the Settings screen, every time you open it. Looking very closely, you can see that it's labeled "Translation", and it briefly appears between "Language" and "Set as default browser" and then animates away.

EXPECTED RESULTS:
No such immediately-disappearing section. I think this settings subarea is off-by-default, so we should fully hide it by default.

Attached video screencast of bug

Set release status flags based on info from the regressing bug 1890838

:giorga, since you are the author of the regressor, bug 1890838, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(giorga)
Severity: -- → S4
Flags: needinfo?(giorga)
Assignee: nobody → giorga

I don't think we need to track this, but it would be nice to verify once it lands in 127.

Flags: qe-verify+
Priority: -- → P2
Whiteboard: [fxdroid][foundation][translations:128]

[Tracking Requested - why for this release]:

(In reply to Liz Henry (:lizzard) (relman/hg->git project) from comment #5)

I don't think we need to track this, but it would be nice to verify once it lands in 127.

Maybe worth tracking to be sure we get the fix uplifted once it lands on nightly which is now 128.

The bug is marked as tracked for firefox127 (beta). However, the bug still has low severity.

:olivia, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Flags: needinfo?(ohall)
Severity: S4 → S3
Flags: needinfo?(ohall)
Flags: qe-verify+

This bug still should be tracked. I moved it up to S3 since it is a very prominent visual glitch and should be uplifted, but it isn't compromising or breaking behavior.

Flags: qe-verify+
Pushed by giorga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/01d5edf7604e "Translation" should be by default invisible in Settings. r=android-reviewers,ohall
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch

Verified as fixed on the latest Fenix Nightly 128.0a1 from 5/16, with Samsung Galaxy Tab S8 Ultra (Android 12), and Google Pixel 6 (Android 14).

Flags: qe-verify+

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(giorga)

Comment on attachment 9401074 [details]
Bug 1896029 - "Translation" should be by default invisible in Settings.

Beta/Release Uplift Approval Request

  • User impact if declined: The user will see a animation when he enters in Setttings.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky
  • String changes made/needed:
  • Is Android affected?: Yes
Flags: needinfo?(giorga)
Attachment #9401074 - Flags: approval-mozilla-beta?

Comment on attachment 9401074 [details]
Bug 1896029 - "Translation" should be by default invisible in Settings.

Approved for 127 beta 3, thanks.

Attachment #9401074 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on the latest Fenix Beta 127.0b3 with the following devices:

  • Google Pixel 6 (Android 14),
  • Realme GT Master Edition (Android 13),
  • Google Pixel 8 (Android 14), and
  • Samsung Galaxy Tab S8 Ultra (Android 12).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: