1896109 - [win] Open dialog has focus clipped options

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 126.0

Affected versions

• 127.0a1 (2024-05-09)
• 126.0
• 125.0.3

Tested platforms

• Affected platforms: Windows 10x64
• Unaffected platforms: Ubuntu 23, macOS

Steps to reproduce

1. Set PDF to Always ask in about:preferences.
2. Open a sample PDF (https://pdfobject.com/pdf/sample.pdf)
3. Observe the dialog.

Expected result

• Options focus rings are not clipped.

Actual result

• Options focus rings are clipped.

Regression range

• Mozregression points at bug 1867769.

Additional notes

• Attached a screenshot.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1867769, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Just to confirm, the name being clipped is not a regression right?

Comment 3

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Just to confirm, the name being clipped is not a regression right?

You are correct! the name being clipped is not a regression from this issue at least. I have filed a separate issue (bug 1896330). Sorry for any confusion and thank you for noticing.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1867769

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1896109 - Stop drawing focus on the label on windows. r=#theme

We switched to non-native checkboxes a while ago, and those draw the
focus themselves.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a67a6e44dc83
Stop drawing focus on the label on windows. r=desktop-theme-reviewers,dao

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a67a6e44dc83

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 128.0a1 (2024-05-30) on Windows 10x64. The options are no longer clipped when focused due to the fact that ther is no focus after the radio button.