1896330 - Open dialog PDF name is clipped when focused

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 126.0

Affected versions

• 127.0a1 (2024-05-09)
• 126.0

Tested platforms

• Affected platforms: Windows 10x64, macOS 12
• Unaffected platforms: Ubuntu 23

Steps to reproduce

1. Set PDF to Always ask in about:preferences.
2. Open a sample PDF (https://pdfobject.com/pdf/sample.pdf)
3. Using the tab keyboard, focus on the PDF name and observe the dialog.

Expected result

• Name is not clipped.

Actual result

• Name is clipped.

Regression range

• Mozregression points at bug 1881256.

Additional notes

• Attached a screenshot.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1881256, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Dão Gottwald [:dao]]

I expect this is due to https://searchfox.org/mozilla-central/rev/ee2ad260c25310a9fbf96031de05bbc0e94394cc/toolkit/themes/shared/global-shared.css#196

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1896330 - Remove plain class from labels. r=dao,#theme

They only reset a margin, so let's do that explicitly instead.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1896330 - Unify unknownContentType.css. r=dao,#theme

Unify the small-indent handling between macOS and Windows / Linux.

The dialog looks good in macOS with that change, and the spacing
differences seemed gratuitous.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1896330 - Stop using the plain class on unknownContentType.xhtml. r=dao,#theme

And remove it from global-shared.css

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db3d166ae144
Remove plain class from labels. r=dao,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/79c772847cee
Unify unknownContentType.css. r=dao,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/90f8db9f10ff
Stop using the plain class on unknownContentType.xhtml. r=dao,desktop-theme-reviewers

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/db3d166ae144
https://hg.mozilla.org/mozilla-central/rev/79c772847cee
https://hg.mozilla.org/mozilla-central/rev/90f8db9f10ff

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: Screen Recording 2024-05-15 at 15.15.03.mov

Hello, it seems this is no longer happening with Firefox 128.0a1 (20240515032356) on Windows 10x64 using the Tab key or by selecting the format type text with the left mouse click.
However, on macOS 12 I see that using the Tab key to select the format type text will move the text to the left, hiding the first letter. This does not happen when clicking the name (see attached screen recording). Is it expected or should I file something minor against this? Thank you in advance!

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Please file it, thanks.

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)

Please file it, thanks.

Thank you! I filed bug 1896901 for the macOS scenario.