ICF detection code doesn't work correctly
Categories
(Firefox Build System :: General, defect, P5)
Tracking
(firefox128 fixed)
Tracking | Status | |
---|---|---|
firefox128 | --- | fixed |
People
(Reporter: sergesanspaille, Assigned: sergesanspaille)
References
Details
Attachments
(1 file)
The following configure invocation shows that icf is not correctly activated when it should be:
./mach configure --enable-release --enable-linker=lld --enable-optimize | grep Folding
0:03.62 checking whether the linker supports Identical Code Folding... no
0:04.67 js/src> checking whether the linker supports Identical Code Folding... (cached) no
Assignee | ||
Comment 1•9 months ago
|
||
Otherwise the two symbols checked have different code and icf doesn't happen.
Comment 2•9 months ago
|
||
The severity field is not set for this bug.
:ahochheiden, could you have a look please?
For more information, please visit BugBot documentation.
Assignee | ||
Updated•9 months ago
|
Updated•9 months ago
|
Updated•9 months ago
|
Updated•8 months ago
|
Comment 4•8 months ago
|
||
bugherder |
Comment 5•8 months ago
|
||
Does this only impact Linux? i.e. did we have ICF working on Windows?
Assignee | ||
Comment 6•8 months ago
|
||
No ICF on WIndows not OSX (because of the linker used). But We should have it on Android soo (see #1899972)
Comment 7•8 months ago
|
||
Actually, lld has ICF support for both macho and COFF, but that's through different flags.
Comment 8•8 months ago
|
||
In fact, we're already enabling ICF on Windows through https://searchfox.org/mozilla-central/rev/59d854a90e036cfa77f3c5b70c8c6ef1d60ebb98/python/mozbuild/mozbuild/frontend/context.py#492
We should probably handle it similarly to what we do on Linux.
Description
•