1899972 - ICF detection code doesn't work correctly on Android

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[[:sergesanspaille]]

On android, even after 1896118, icf configure code doesn't correctly detect support for -Wl,--icf=safe

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1899972 - Improve identical code folding with -faddrsig on Android r=glandium!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1fd0a5e3c8f
Improve identical code folding with -faddrsig on Android r=glandium

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f1fd0a5e3c8f

Comment 4

[Chris Peterson [:cpeterson]]

Serge, do you think ICF is safe to uplift to Beta 128? Have you heard of any problems from ICF in Nightly 129 this last week?

Perfherder says ICF trimmed almost 3 MB off the Fenix APK size:

https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&replicates=0&series=firefox-android,4670242,1,2&series=mozilla-central,5059175,1,2&series=mozilla-central,5059176,1,2&series=mozilla-central,5059177,1,2&series=mozilla-central,5059178,1,2&timerange=2592000

Comment 5

[[:sergesanspaille]]

Yeah, should be safe.

Comment 6

[Chris Peterson [:cpeterson]]

Comment on attachment 9405289 [details]
Bug 1899972 - Improve identical code folding with -faddrsig on Android r=glandium!

Beta/Release Uplift Approval Request

• User impact if declined: New users will have to download an extra 3 MB of APK when installing Firefox (and maybe ~1.5 MB install footprint on-device). For reference, the current ARM64 APK is about 103 MB.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch removes some unnecessary code and has baked on Nightly for 10+ days.
• String changes made/needed: N/A
• Is Android affected?: Yes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9405289 [details]
Bug 1899972 - Improve identical code folding with -faddrsig on Android r=glandium!

This doesn't graft cleanly to Beta.

Comment 8

[Mike Hommey [:glandium]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)

Comment on attachment 9405289 [details]
Bug 1899972 - Improve identical code folding with -faddrsig on Android r=glandium!

This doesn't graft cleanly to Beta.

Because of the dependency.

Comment 9

[Chris Peterson [:cpeterson]]

This doesn't graft cleanly to Beta.

In that case, let's not uplift. I mistakenly thought this would be a straightforward uplift. The improvement can wait until 129.

firefox28=wontfix