1896140 - [HCM] Hover effect visibility issues on Windows for the Cancel and Retry buttons

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Screen recording with High Contrast #1.gif

Found in

• Nightly 127.0a1

Affected versions

• Nightly 127.0a1

Tested platforms

• Affected platforms: Windows 10,

Preconditions

• Enable High Contrast Mode.

Steps to reproduce

1. Enable Screenshots by pressing the Ctrl+Shift+S keys.
2. Click on the Save Visible button and hover the mouse over all the buttons: Download, Copy, Cancel and Retry Screenshots.

Expected result

• All the buttons should be visible, and the mouse hover effect should be noticeable.

Actual result

• The hover effect for the Cancel and Retry buttons is not very visible when the High Contrast White theme is enabled and is having some contrast issue with the High Contrast #1 and High Contrast #2 themes.

Regression range
Found commit message:
Bug 1892125 - Refactor screenshots preview. r=sfoster,fluent-reviewers,desktop-theme-reviewers,bolsson

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0c04b1ea36b920ada23761d968adeecaf7a401b4&tochange=fd2691d9e2d91007f848e13f7ba13cd226fcfa7c

Comment 1

[Simona Badau, Desktop QA]

Attachment: Screen recording with High Contrast #1.gif

Comment 2

[Simona Badau, Desktop QA]

Attachment: Screen recording with High Contrast White.gif

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:niklas, since you are the author of the regressor, bug 1892125, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1896140 - Unlabeled button color should match labeled button color. r=#recomp-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/412893b06d56
Unlabeled button color should match labeled button color. r=reusable-components-reviewers,desktop-theme-reviewers,mstriemer

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest perma failures @ toolkit/content/tests/widgets/test_moz_button.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/d2559b875116c39b9f40c8860f487916db812831

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_moz_button.html | fill should be --icon-color - got "rgba(21, 20, 26, 1)", expected "rgba(91, 91, 102, 1)

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

• Bug 1894820: S3

:niklas, could you consider increasing the severity of this bug to S3?

For more information, please visit BugBot documentation.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1892125

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48b3f8922897
Unlabeled button color should match labeled button color. r=reusable-components-reviewers,desktop-theme-reviewers,mstriemer

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/48b3f8922897

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Niklas Baumgardner [:niklas]]

Comment on attachment 9401163 [details]
Bug 1896140 - Unlabeled button color should match labeled button color. r=#recomp-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Buttons in HCM do not have enough contrast when hovered.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Preconditions

• Enable High Contrast Mode.

Steps to reproduce

1. Enable Screenshots by pressing the Ctrl+Shift+S keys.
2. Click on the Save Visible button and hover the mouse over all the buttons: Download, Copy, Cancel and Retry Screenshots.

Expected result:
All the buttons should be visible, and the mouse hover effect should be noticeable.
The contrast between the retry and cancel button should be noticeable when hovering those buttons

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change only removed 1 line of CSS.
• String changes made/needed: No
• Is Android affected?: No

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9401163 [details]
Bug 1896140 - Unlabeled button color should match labeled button color. r=#recomp-reviewers

Approved for 127 beta 3, thanks.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d159e86b01b0

Comment 16

[Simona Badau, Desktop QA]

Attachment: Hover effect with High Contrast White

I confirm that the mouse hover effect on the Cancel and Retry buttons is now more visible - verified using the latest Nightly 128.0a1 on Windows 10.

However, I've noticed that when the High Contrast White theme is enabled, the hover effect is still not very evident. Is this in accordance with the high contrast specifications, or should I log a new bug to cover this specific theme?

Comment 17

[Simona Badau, Desktop QA]

Verified as fixed using Firefox 127.0b3 - tested on Windows 10 and Windows 11.