1896187 - Reuse jexl expressions and Nimbus targeting work for featuregates

Status: RESOLVED FIXED

(Toolkit :: FeatureGate, task, P2)

Description

[:Gijs (he/him)]

It doesn't really make sense to have an additional way of specifying whether a feature/experiment/toggle/whatever is available on a given build specific to features.toml and the FeatureGate code. Although it's not surprising that, when this was built, it relied on the ifdef mechanisms that we use for C++/JS that's part of the browser, there doesn't seem to be a reason not to switch this over to the JEXL based checks we use for Nimbus.

Longer term this may help us to move the consumers of FeatureGate to Nimbus altogether, although that is a larger project. In the interim, this is about 200 lines of net code removal so that seems useful in and of itself.

Note that at least in the interim, the default value of a given FeatureGate must match the default value of its pref, which is determined at compile-time, and so this doesn't immediately yield more expressiveness (e.g. we can't immediately filter on geo or other runtime characteristics). We'll likely investigate how to change this in future. However, it does yield more expressiveness for where we expose features in this way, which is desirable especially on non-nightly branches. Either way this is about 200 lines of code removal. 🎉

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1896187 - make FeatureGate 'features to try' page use the same jexl filtering as Nimbus, r?barret!,#settings-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a74adb44160
make FeatureGate 'features to try' page use the same jexl filtering as Nimbus, r=barret,settings-reviewers,mconley

Comment 3

[:Gijs (he/him)]

Attachment: WIP: Bug 1896187 - bustage fix: set defaults for parsed feature gates correctly in python generation now that properties have been renamed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9654aaf21d82
bustage fix: set defaults for parsed feature gates correctly in python generation now that properties have been renamed. CLOSED TREE

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ toolkit/components/featuregates/test/unit/test_FeatureGate.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/abdfc5289589473083a6cfc3ccb8657f751d20a4

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | xpcshell return code: 0

Failure log -> toolkit/components/featuregates/test/python/test_gen_feature_definitions.py::TestProcessFiles::test_valid_file TEST-UNEXPECTED-FAIL

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_experimental_features_filter.js | Uncaught exception in test bound testFilterFeatures - wait for the first public feature to get added to the DOM - timed out after 50 tries

Comment 6

[:Gijs (he/him)]

https://treeherder.mozilla.org/jobs?repo=try&revision=b34df3a7eaf81d25c8c6a2b3d36c77845a63546e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1974e2a74ac3
make FeatureGate 'features to try' page use the same jexl filtering as Nimbus, r=barret,settings-reviewers,mconley

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1974e2a74ac3